From 349230f2f52f1123eeb72cfe9e10b06f2f07cd38 Mon Sep 17 00:00:00 2001 From: Naz Date: Tue, 5 Oct 2021 13:47:15 +0200 Subject: [PATCH] Removed commented post.save call in puglishmenu refs https://linear.app/tryghost/issue/CORE-71/email-only-posts-hand-off - The piece of code was commented out with an intention of keeping an existing pattern of only calling post's save's when edits are done in the editor or PSM. The changes in the publishmenu should not effect the model and have a need to save it - The side-effect that still needs to be sorted is the change to the 'saveType' is effecting a model and causes a confirmation modal when leaving the post screen --- ghost/admin/app/components/gh-publishmenu.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/ghost/admin/app/components/gh-publishmenu.js b/ghost/admin/app/components/gh-publishmenu.js index c60f220c71..0b17eccab1 100644 --- a/ghost/admin/app/components/gh-publishmenu.js +++ b/ghost/admin/app/components/gh-publishmenu.js @@ -458,9 +458,5 @@ export default Component.extend({ this.post.set('statusScratch', null); this.post.validate(); - // TODO: confirm with Naz why this is needed and find a different solution - // - we shouldn't be saving post data every time the menu is closed, - // especially when the user has chosen to cancel/close the menu without saving - // this.post.save(); } });