TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-25 09:03:12 +03:00
Code Issues Projects Releases Wiki Activity

✨ Added "Last seen" filter to members screen

Browse Source 
refs https://github.com/TryGhost/Team/issues/1418

- adds "Last seen" option to members filtering that lets you filter by date a member last logged in or opened an email with `before`, `on or before`, `on or after`, and `after` options
- adds "Last seen on x" data to the member details screen
This commit is contained in:
Kevin Ansfield 2022-03-08 20:21:49 +00:00
parent 4562476d4e
commit 3a9ea11213
5 changed files with 12 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
ghost/admin/app/components/gh-member-details.hbs
View File

@ -44,18 +44,16 @@
</p>
<p>
{{svg-jar "member-add"}}
Created on {{moment-format @member.createdAtUTC "D MMM YYYY"}}
Created on {{moment-format (moment-site-tz @member.createdAtUTC) "D MMM YYYY"}}
</p>
<p class="gh-member-last-seen">
{{svg-jar "eye"}}
{{#if (not (is-empty @member.lastSeenAtUTC))}}
Last seen on {{moment-format (moment-site-tz @member.lastSeenAtUTC) "D MMM YYYY"}}
{{else}}
<span>Not seen yet</span>
{{/if}}
</p>
{{#if (feature "membersLastSeenFilter")}}
<p class="gh-member-last-seen">
{{svg-jar "eye"}}
{{#if (not (is-empty @member.lastSeenAtUTC))}}
Last seen on {{moment-format @member.lastSeenAtUTC "D MMM YYYY"}}
{{else}}
<span>Not seen yet</span>
{{/if}}
</p>
{{/if}}
</div>
{{#if (and (not-eq this.settings.membersSignupAccess "none") (not-eq this.settings.editorDefaultEmailRecipients "disabled"))}}
<div class="gh-member-details-stats-container">
@ -64,9 +62,9 @@
<div class="gh-members-no-stats">
<p>
{{#if @member.name}}
We'll show {{first-name @member.name}}'s email stats here once they receive their first newsletter.
We'll show {{first-name @member.name}}'s email stats here once they receive their first newsletter.
{{else}}
We'll show this member's email stats here once they receive their first newsletter.
We'll show this member's email stats here once they receive their first newsletter.
{{/if}}
</p>
</div>

2
ghost/admin/app/components/members/filter.js
View File

@ -14,7 +14,7 @@ const FILTER_PROPERTIES = [
// {label: 'Location', name: 'location', group: 'Basic'},
{label: 'Label', name: 'label', group: 'Basic', valueType: 'array'},
{label: 'Newsletter subscription', name: 'subscribed', group: 'Basic'},
{label: 'Last seen', name: 'last_seen_at', group: 'Basic', valueType: 'date', feature: 'membersLastSeenFilter'},
{label: 'Last seen', name: 'last_seen_at', group: 'Basic', valueType: 'date'},
{label: 'Created', name: 'created_at', group: 'Basic', valueType: 'date'},
// Member subscription

3
ghost/admin/app/services/feature.js
View File

@ -90,9 +90,6 @@ export default class FeatureService extends Service {
@feature('membersTableStatus')
membersTableStatus;
@feature('membersLastSeenFilter')
membersLastSeenFilter;
@feature('membersContainsFilters')
membersContainsFilters;

13
ghost/admin/app/templates/settings/labs.hbs
View File

@ -365,19 +365,6 @@
</div>
</div>
</div>
<div class="gh-expandable-block">
<div class="gh-expandable-header">
<div>
<h4 class="gh-expandable-title">Members "Last seen" filter</h4>
<p class="gh-expandable-description">
Filter members by the date they were last seen (logged in or read an email)
</p>
</div>
<div class="for-switch">
<GhFeatureFlag @flag="membersLastSeenFilter" />
</div>
</div>
</div>
<div class="gh-expandable-block">
<div class="gh-expandable-header">
<div>

1
ghost/admin/tests/acceptance/members/filter-test.js
View File

@ -19,7 +19,6 @@ describe('Acceptance: Members filtering', function () {
beforeEach(async function () {
this.server.loadFixtures('configs');
this.server.loadFixtures('settings');
enableLabsFlag(this.server, 'membersLastSeenFilter');
enableLabsFlag(this.server, 'multipleProducts');
// test with stripe connected and email turned on