TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-01 05:50:35 +03:00
Code Issues Projects Releases Wiki Activity

Handled duplicated authors

Browse Source 
no issue

- discovered while testing
- the matching helper can fallback twice to owner user in theory
This commit is contained in:
kirrg001 2019-02-18 19:30:11 +01:00
parent a575f85af7
commit 3b2ede88e0
1 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
core/server/models/relations/authors.js
View File

@ -228,6 +228,13 @@ module.exports.extendModel = function extendModel(Post, Posts, ghostBookshelf) {
return attrs;
},
/**
* Authors relation is special. You cannot add new authors via relations.
* But you can for the tags relation. That's why we have to sort this out before
* we trigger bookshelf-relations.
*
* @TODO: Add a feature to bookshelf-relations to configure if relations can be added or should be matched only.
*/
matchAuthors(model, options) {
let ownerUser;
const ops = [];
@ -243,6 +250,7 @@ module.exports.extendModel = function extendModel(Post, Posts, ghostBookshelf) {
ops.push(() => {
const authors = model.get('authors');
const authorsToSet = [];
return Promise.each(authors, (author, index) => {
const query = {};
@ -260,16 +268,18 @@ module.exports.extendModel = function extendModel(Post, Posts, ghostBookshelf) {
.where(query)
.fetch(Object.assign({columns: ['id']}, _.pick(options, 'transacting')))
.then((user) => {
authors[index] = {};
let userId = user ? user.id : ownerUser.id;
if (!user) {
authors[index].id = ownerUser.id;
} else {
authors[index].id = user.id;
// CASE: avoid attaching duplicate authors relation
const userExists = _.find(authorsToSet, {id: userId.id});
if (!userExists) {
authorsToSet[index] = {};
authorsToSet[index].id = userId;
}
});
}).then(() => {
model.set('authors', authors);
model.set('authors', authorsToSet);
});
});