From 3fafc4a48a12e0b0a8da15f2097649b75dd5ca71 Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Fri, 5 Nov 2021 10:47:39 +0000 Subject: [PATCH] Fixed `{{movable}}` stopping text input selection and allowing drag of dropdown elems no issue - stops drag from being initiated from any element that matches `input` or `.ember-basic-dropdown-trigger` so that text can still be selected from inputs whilst dragging and we don't get left with orphaned dropdowns from dragging a dropdown-inducing element --- ghost/admin/app/modifiers/movable.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ghost/admin/app/modifiers/movable.js b/ghost/admin/app/modifiers/movable.js index 8acbae5e5e..755c9740df 100644 --- a/ghost/admin/app/modifiers/movable.js +++ b/ghost/admin/app/modifiers/movable.js @@ -62,6 +62,10 @@ export default class MovableModifier extends Modifier { } for (const elem of (e.path || e.composedPath())) { + if (elem.matches('input, .ember-basic-dropdown-trigger')) { + break; + } + if (elem === this.element) { this.addActiveEventListeners(); break;