From 45de9b0efc78b938272427d30fe963784435f550 Mon Sep 17 00:00:00 2001 From: Hannah Wolfe Date: Thu, 24 Mar 2022 17:25:53 +0000 Subject: [PATCH] Fixed filename casing in canary API refs: https://github.com/TryGhost/Ghost/commit/0ef5a5c97a5164f85126f7e9518b859aaf4bf3bd - As per the previous commit, our mixed filename casing inadvertently resulted in a bug - The casing in the codebase is meant to be kebab-case always, so fixing this everywhere that's relevant to the API whilst there's a good reason --- core/server/api/canary/index.js | 4 ++-- .../api/canary/{memberSigninUrls.js => member-signin-urls.js} | 0 .../{membersStripeConnect.js => members-stripe-connect.js} | 0 core/server/api/canary/utils/serializers/output/index.js | 2 +- .../output/{member-signin_urls.js => member-signin-urls.js} | 0 ...m_theme_settings.test.js => custom-theme-settings.test.js} | 0 .../admin/{email_preview.test.js => email-preview.test.js} | 0 ...{key_authentication.test.js => key-authentication.test.js} | 0 ...{members_signin_url.test.js => members-signin-url.test.js} | 0 9 files changed, 3 insertions(+), 3 deletions(-) rename core/server/api/canary/{memberSigninUrls.js => member-signin-urls.js} (100%) rename core/server/api/canary/{membersStripeConnect.js => members-stripe-connect.js} (100%) rename core/server/api/canary/utils/serializers/output/{member-signin_urls.js => member-signin-urls.js} (100%) rename test/e2e-api/admin/{custom_theme_settings.test.js => custom-theme-settings.test.js} (100%) rename test/e2e-api/admin/{email_preview.test.js => email-preview.test.js} (100%) rename test/e2e-api/admin/{key_authentication.test.js => key-authentication.test.js} (100%) rename test/regression/api/admin/{members_signin_url.test.js => members-signin-url.test.js} (100%) diff --git a/core/server/api/canary/index.js b/core/server/api/canary/index.js index 60c8f5d114..6f9ce78fb7 100644 --- a/core/server/api/canary/index.js +++ b/core/server/api/canary/index.js @@ -78,7 +78,7 @@ module.exports = { }, get membersStripeConnect() { - return shared.pipeline(require('./membersStripeConnect'), localUtils); + return shared.pipeline(require('./members-stripe-connect'), localUtils); }, get members() { @@ -98,7 +98,7 @@ module.exports = { }, get memberSigninUrls() { - return shared.pipeline(require('./memberSigninUrls.js'), localUtils); + return shared.pipeline(require('./member-signin-urls.js'), localUtils); }, get labels() { diff --git a/core/server/api/canary/memberSigninUrls.js b/core/server/api/canary/member-signin-urls.js similarity index 100% rename from core/server/api/canary/memberSigninUrls.js rename to core/server/api/canary/member-signin-urls.js diff --git a/core/server/api/canary/membersStripeConnect.js b/core/server/api/canary/members-stripe-connect.js similarity index 100% rename from core/server/api/canary/membersStripeConnect.js rename to core/server/api/canary/members-stripe-connect.js diff --git a/core/server/api/canary/utils/serializers/output/index.js b/core/server/api/canary/utils/serializers/output/index.js index 525231b0a2..fb6514efe0 100644 --- a/core/server/api/canary/utils/serializers/output/index.js +++ b/core/server/api/canary/utils/serializers/output/index.js @@ -74,7 +74,7 @@ module.exports = { }, get member_signin_urls() { - return require('./member-signin_urls'); + return require('./member-signin-urls'); }, get identities() { diff --git a/core/server/api/canary/utils/serializers/output/member-signin_urls.js b/core/server/api/canary/utils/serializers/output/member-signin-urls.js similarity index 100% rename from core/server/api/canary/utils/serializers/output/member-signin_urls.js rename to core/server/api/canary/utils/serializers/output/member-signin-urls.js diff --git a/test/e2e-api/admin/custom_theme_settings.test.js b/test/e2e-api/admin/custom-theme-settings.test.js similarity index 100% rename from test/e2e-api/admin/custom_theme_settings.test.js rename to test/e2e-api/admin/custom-theme-settings.test.js diff --git a/test/e2e-api/admin/email_preview.test.js b/test/e2e-api/admin/email-preview.test.js similarity index 100% rename from test/e2e-api/admin/email_preview.test.js rename to test/e2e-api/admin/email-preview.test.js diff --git a/test/e2e-api/admin/key_authentication.test.js b/test/e2e-api/admin/key-authentication.test.js similarity index 100% rename from test/e2e-api/admin/key_authentication.test.js rename to test/e2e-api/admin/key-authentication.test.js diff --git a/test/regression/api/admin/members_signin_url.test.js b/test/regression/api/admin/members-signin-url.test.js similarity index 100% rename from test/regression/api/admin/members_signin_url.test.js rename to test/regression/api/admin/members-signin-url.test.js