TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-26 12:21:36 +03:00
Code Issues Projects Releases Wiki Activity

Added column sorting and removed the dropdown

Browse Source 
refs https://github.com/TryGhost/Team/issues/1986
This commit is contained in:
Djordje Vlaisavljevic 2022-10-07 10:42:44 +02:00 committed by Rishabh Garg
parent 15fbd3d7e6
commit 4704e7ab31
2 changed files with 5 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ghost/admin/app/components/dashboard/charts/attribution.hbs
View File

@ -8,29 +8,13 @@
<p>Once someone signs up, you’ll be able to see where they came from here.</p> <p>Once someone signs up, you’ll be able to see where they came from here.</p>
</div> </div>
{{else}} {{else}}
<div class="gh-dashboard-select">
<PowerSelect
@selected={{this.selectedDisplayOption}}
@options={{this.allowedDisplayOptions}}
@searchEnabled={{false}}
@onChange={{this.onDisplayChange}}
@triggerComponent={{component "gh-power-select/trigger"}}
@triggerClass="gh-contentfilter-menu-trigger"
@dropdownClass="gh-contentfilter-menu-dropdown is-narrow"
@matchTriggerWidth={{false}}
@horizontalPosition="right"
@disabled={{this.isDropdownDisabled}}
as |option|
>
{{#if option.name}}{{option.name}}{{else}}<span class="red">Unknown option</span>{{/if}}
</PowerSelect>
</div>
<div class="gh-dashboard-attribution-grid"> <div class="gh-dashboard-attribution-grid">
<div> <div>
<h3 class="gh-dashboard-metric-label">Top sources</h3> <h3 class="gh-dashboard-metric-label">Top sources</h3>
<MemberAttribution::SourceAttributionTable <MemberAttribution::SourceAttributionTable
@sources={{this.sources}} @sources={{this.sources}}
@sortColumn={{this.selectedSortColumn}} @sortColumn={{this.selectedSortColumn}}
@setSortColumn={{this.setSortColumn}}
class="gh-dashboard-attribution-list gh-dashboard-list" class="gh-dashboard-attribution-list gh-dashboard-list"
/> />
</div> </div>

4
ghost/admin/app/components/member-attribution/source-attribution-table.hbs
View File

@ -2,13 +2,17 @@
<div class="gh-dashboard-list-header"> <div class="gh-dashboard-list-header">
<div class="gh-dashboard-list-title gh-dashboard-list-title-sources">Sources</div> <div class="gh-dashboard-list-title gh-dashboard-list-title-sources">Sources</div>
<div <div
role="button" aria-label="Sort by free signups"
class="gh-dashboard-list-title {{if (eq @sortColumn "signups") "sorted-by"}}" class="gh-dashboard-list-title {{if (eq @sortColumn "signups") "sorted-by"}}"
{{on "click" (fn @setSortColumn "signups")}}
> >
<span class="hide-when-small">Free </span>signups{{svg-jar "arrow-down-fill"}} <span class="hide-when-small">Free </span>signups{{svg-jar "arrow-down-fill"}}
</div> </div>
{{#if this.membersUtils.paidMembersEnabled}} {{#if this.membersUtils.paidMembersEnabled}}
<div <div
role="button" aria-label="Sort by paid conversions"
class="gh-dashboard-list-title {{if (eq @sortColumn "paid") "sorted-by"}}" class="gh-dashboard-list-title {{if (eq @sortColumn "paid") "sorted-by"}}"
{{on "click" (fn @setSortColumn "paid")}}
> >
<span class="hide-when-small">Paid </span>Conversions{{svg-jar "arrow-down-fill"}} <span class="hide-when-small">Paid </span>Conversions{{svg-jar "arrow-down-fill"}}
</div> </div>