fix bug with config service interpreting rare client secret strings as exponential numbers

closes #5815
- replaces isNaN function call with isFinite in config service
- adds config service unit test
This commit is contained in:
Austin Burdine 2015-09-09 08:19:45 -05:00
parent 4ff23ec9f0
commit 497a74beb0
2 changed files with 35 additions and 1 deletions

View File

@ -1,7 +1,7 @@
import Ember from 'ember';
function isNumeric(num) {
return !isNaN(num);
return Ember.$.isNumeric(num);
}
function _mapType(val) {

View File

@ -0,0 +1,34 @@
/* jshint expr:true */
import { expect } from 'chai';
import {
describeModule,
it
} from 'ember-mocha';
import Ember from 'ember';
describeModule(
'service:config',
'ConfigService',
{
// Specify the other units that are required for this test.
// needs: ['service:foo']
},
function () {
// Replace this with your real tests.
it('exists', function () {
var service = this.subject();
expect(service).to.be.ok;
});
it('correctly parses a client secret', function () {
Ember.$('<meta>').attr('name', 'env-clientSecret')
.attr('content', '23e435234423')
.appendTo('head');
var service = this.subject();
expect(service.get('clientSecret')).to.equal('23e435234423');
});
}
);