TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-01 22:02:11 +03:00
Code Issues Projects Releases Wiki Activity

Remove sanitize() from model/base because clean code

Browse Source
This commit is contained in:
Joerg Henning 2016-04-01 00:01:11 +08:00
parent 5f8ef26eb3
commit 4a3d8c7ae8
3 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
core/server/models/base/index.js
View File

@ -13,7 +13,6 @@ var _ = require('lodash'),
filters = require('../../filters'), filters = require('../../filters'),
moment = require('moment'), moment = require('moment'),
Promise = require('bluebird'), Promise = require('bluebird'),
sanitizer = require('validator').sanitize,
schema = require('../../data/schema'), schema = require('../../data/schema'),
utils = require('../../utils'), utils = require('../../utils'),
uuid = require('node-uuid'), uuid = require('node-uuid'),
@ -183,10 +182,6 @@ ghostBookshelf.Model = ghostBookshelf.Model.extend({
return proto.finalize.call(this, attrs); return proto.finalize.call(this, attrs);
}, },
sanitize: function sanitize(attr) {
return sanitizer(this.get(attr)).xss();
},
// Get attributes that have been updated (values before a .save() call) // Get attributes that have been updated (values before a .save() call)
updatedAttributes: function updatedAttributes() { updatedAttributes: function updatedAttributes() {
return this._updatedAttributes || {}; return this._updatedAttributes || {};

1
core/server/models/post.js
View File

@ -124,7 +124,6 @@ Post = ghostBookshelf.Model.extend({
this.set('html', converter.makeHtml(this.get('markdown'))); this.set('html', converter.makeHtml(this.get('markdown')));
// disabling sanitization until we can implement a better version // disabling sanitization until we can implement a better version
// this.set('title', this.sanitize('title').trim());
title = this.get('title') || i18n.t('errors.models.post.untitled'); title = this.get('title') || i18n.t('errors.models.post.untitled');
this.set('title', title.trim()); this.set('title', title.trim());

11
core/server/models/settings.js
View File

@ -87,18 +87,7 @@ Settings = ghostBookshelf.Model.extend({
return validation.validateActiveTheme(themeName); return validation.validateActiveTheme(themeName);
}); });
},
saving: function saving() {
// disabling sanitization until we can implement a better version
// All blog setting keys that need their values to be escaped.
// if (this.get('type') === 'blog' && _.contains(['title', 'description', 'email'], this.get('key'))) {
// this.set('value', this.sanitize('value'));
// }
return ghostBookshelf.Model.prototype.saving.apply(this, arguments);
} }
}, { }, {
findOne: function (options) { findOne: function (options) {
// Allow for just passing the key instead of attributes // Allow for just passing the key instead of attributes