From 4c4591894e33b9fb896c74c44947fea72748c66c Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Mon, 4 Apr 2022 09:43:54 +0100 Subject: [PATCH 1/3] =?UTF-8?q?=F0=9F=90=9B=20Fixed=20incorrect=20modal=20?= =?UTF-8?q?and=20theme=20preview=20positioning?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit closes https://github.com/TryGhost/Ghost/issues/14415 - after switching to a proper package version of our `ember-promise-modals` fork the addon's CSS was injected into the vendor file causing conflicts with our own modal styling - added `transform: none` style override on `.epm-modal` so we're not fighting the addon's default `translate(0, -30vh) scale(1.1);` transform --- ghost/admin/app/styles/components/modals-new.css | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ghost/admin/app/styles/components/modals-new.css b/ghost/admin/app/styles/components/modals-new.css index fbd810f3a3..e18b112219 100644 --- a/ghost/admin/app/styles/components/modals-new.css +++ b/ghost/admin/app/styles/components/modals-new.css @@ -72,6 +72,7 @@ animation-duration: var(--epm-animation-modal-in-duration); -webkit-overflow-scrolling: touch; /* momentum-based scrolling for Safari on iOS */ pointer-events: none; + transform: none; } .epm-modal * { @@ -99,6 +100,7 @@ animation-delay: var(--epm-animation-modal-out-delay); animation-duration: var(--epm-animation-modal-out-duration); pointer-events: none; + transform: none; } @keyframes epm-backdrop-in { From 7e915fa6757b93f4dc8babe171c1f6448b983b94 Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Mon, 4 Apr 2022 09:55:33 +0100 Subject: [PATCH 2/3] =?UTF-8?q?=F0=9F=90=9B=20Fixed=20incorrect=20modal=20?= =?UTF-8?q?heights?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit closes https://github.com/TryGhost/Ghost/issues/14416 refs https://github.com/TryGhost/Admin/commit/1357390ac5b30b52a15b5882e0cdf3ebfac36010 - after switching to a proper package version of our `ember-promise-modals` fork the addon's CSS was injected into the vendor file causing conflicts with our own modal styling - added `align-items: unset` style override on `.epm-modal-container` so we're not fighting the addon's default `align-items: center;` style --- ghost/admin/app/styles/components/modals-new.css | 1 + 1 file changed, 1 insertion(+) diff --git a/ghost/admin/app/styles/components/modals-new.css b/ghost/admin/app/styles/components/modals-new.css index e18b112219..1a07a585b5 100644 --- a/ghost/admin/app/styles/components/modals-new.css +++ b/ghost/admin/app/styles/components/modals-new.css @@ -59,6 +59,7 @@ display: flex; justify-content: center; overflow: auto; + align-items: unset; } .epm-animating .epm-modal-container { From 0880b3dd85eb7ea2b8f3f6c1c7d4198edc7888c8 Mon Sep 17 00:00:00 2001 From: Daniel Lockyer Date: Mon, 4 Apr 2022 10:39:50 +0100 Subject: [PATCH 3/3] v4.42.1 --- ghost/admin/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ghost/admin/package.json b/ghost/admin/package.json index 7833e44908..5445d92267 100644 --- a/ghost/admin/package.json +++ b/ghost/admin/package.json @@ -1,6 +1,6 @@ { "name": "ghost-admin", - "version": "4.42.0", + "version": "4.42.1", "description": "Ember.js admin client for Ghost", "author": "Ghost Foundation", "homepage": "http://ghost.org",