TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-28 05:37:34 +03:00
Code Issues Projects Releases Wiki Activity

Added show/hide comment CTA to preview labs view

Browse Source 
refs https://github.com/TryGhost/Team/issues/2714

Uses the comments settings and the showCommentCta setting from the newsletter.
This commit is contained in:
Simon Backx 2023-03-15 10:16:05 +01:00
parent 42d9c3ea4d
commit 4cc7d7d6d1
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ghost/admin/app/components/modals/newsletters/edit/preview-labs.hbs
View File

@ -32,9 +32,9 @@
<p>By {{or this.session.user.name this.session.user.email}} on {{moment-format (moment-site-tz) "D MMM YYYY"}}</p>
<div class="{{if (eq @newsletter.titleAlignment "center") "gh-members-emailpreview-meta-center"}}">
<a href="javascript:">View in browser</a>
{{!-- {{#if newsletter.showCommentCta}} --}}
{{#if this.showCommentCta}}
<a href="javascript:"> {{svg-jar "comments"}}</a>
{{!-- {{/if}} --}}
{{/if}}
</div>
</div>
</div>
@ -49,7 +49,7 @@
<p>So, you can trust that every email you send with Ghost will look great and work well. Just like the rest of your site.</p>
</div>
{{!-- {{#if (or (and @newsletter.feedbackEnabled (feature "audienceFeedback")) newsletter.showCommentCta)}} --}}
{{#if (or (and @newsletter.feedbackEnabled (feature "audienceFeedback")) this.showCommentCta)}}
<div class="gh-members-emailpreview-feedback gh-members-emailpreview-content">
<div class="gh-members-emailpreview-feedback-buttons-group">
@ -63,14 +63,14 @@
@icon="thumbs-down" />
{{/if}}
{{!-- {{#if newsletter.showCommentCta}} --}}
{{#if this.showCommentCta}}
<Modals::Newsletters::Components::FeedbackButton
@text="Comments"
@icon="comments" />
{{!-- {{/if}} --}}
{{/if}}
</div>
</div>
{{!-- {{/if}} --}}
{{/if}}
<div class="gh-members-emailpreview-footer">
<div class="gh-members-emailpreview-footercontent">

4
ghost/admin/app/components/modals/newsletters/edit/preview-labs.js
View File

@ -16,6 +16,10 @@ export default class EditNewsletterPreview extends Component {
return this.headerTitle || this.headerSubtitle;
}
get showCommentCta() {
return this.args.newsletter.showCommentCta && this.settings.commentsEnabled !== 'off';
}
get headerTitle() {
if (this.args.newsletter.showHeaderTitle) {
return this.settings.title;