TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-18 16:01:40 +03:00
Code Issues Projects Releases Wiki Activity

Fixed model validation erroneously triggering on non-nullable text fields

Browse Source 
refs https://github.com/TryGhost/Toolbox/issues/309

- I've just ran into a problem when deleting the `defaultTo` field on a
  non-nullable `text` column in our schema because this validation
  thinks there should be a value set
- `text` fields cannot have defaults so the schema is incorrect, and the
  validation triggering is a bug that's preventing it from being
  cleaned up
- the default is defined on the model so I don't think we're losing
  anything here
This commit is contained in:
Daniel Lockyer 2022-05-05 14:46:50 +01:00
parent 002cf5b0eb
commit 51498abb5c
No known key found for this signature in database
GPG Key ID: D21186F0B47295AD
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/server/data/schema/validator.js
View File

@ -45,6 +45,8 @@ function validateSchema(tableName, model, options) {
// check nullable // check nullable
if (Object.prototype.hasOwnProperty.call(schema[tableName][columnKey], 'nullable') && if (Object.prototype.hasOwnProperty.call(schema[tableName][columnKey], 'nullable') &&
schema[tableName][columnKey].nullable !== true && schema[tableName][columnKey].nullable !== true &&
Object.prototype.hasOwnProperty.call(schema[tableName][columnKey], 'type') &&
schema[tableName][columnKey].type !== 'text' &&
!Object.prototype.hasOwnProperty.call(schema[tableName][columnKey], 'defaultTo') !Object.prototype.hasOwnProperty.call(schema[tableName][columnKey], 'defaultTo')
) { ) {
if (validator.isEmpty(strVal)) { if (validator.isEmpty(strVal)) {