TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-23 22:11:09 +03:00
Code Issues Projects Releases Wiki Activity

Removed retries from batch sending tests (#20934)

Browse Source 
no issue

- These retries were added a while ago when these tests were flaking in
CI, but this only serves to cover up any potential problems with these
tests or the code they are testing
- Ran these tests in CI three times in a row without them failing, so I
don't think the retries are necessary
This commit is contained in:
Chris Raible 2024-09-05 16:29:16 -07:00 committed by GitHub
parent 07932325f4
commit 55e6166618
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ghost/core/test/integration/services/email-service/batch-sending.test.js
View File

@ -170,7 +170,6 @@ describe('Batch sending tests', function () {
}); });
it('Protects the email job from being run multiple times at the same time', async function () { it('Protects the email job from being run multiple times at the same time', async function () {
this.retries(1);
// Prepare a post and email model // Prepare a post and email model
const {emailModel} = await sendEmail(agent); const {emailModel} = await sendEmail(agent);
@ -679,7 +678,6 @@ describe('Batch sending tests', function () {
}); });
it('Does replace with and without fallback in both plaintext and html for member with name', async function () { it('Does replace with and without fallback in both plaintext and html for member with name', async function () {
this.retries(1);
// Create a new member without a first_name // Create a new member without a first_name
await models.Member.add({ await models.Member.add({
name: 'Simon Tester', name: 'Simon Tester',
@ -855,7 +853,6 @@ describe('Batch sending tests', function () {
}); });
it('Shows subscription details box for free members', async function () { it('Shows subscription details box for free members', async function () {
this.retries(1);
// Create a new member without a first_name // Create a new member without a first_name
await models.Member.add({ await models.Member.add({
email: 'subscription-box-1@example.com', email: 'subscription-box-1@example.com',