TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-01 13:54:35 +03:00
Code Issues Projects Releases Wiki Activity

Logging for image size (#8978)

Browse Source 
no issue

- added debug logs to image size util and related fn:
    - when fetched via network request
    - when fetched from storage
    - when added to cache
    - when read from cache
This commit is contained in:
Aileen Nowak 2017-09-07 16:34:10 +07:00 committed by Hannah Wolfe
parent 6c47285bba
commit 56d64e53bf
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/server/utils/cached-image-size-from-url.js
View File

@ -1,4 +1,5 @@
var Promise = require('bluebird'),
var debug = require('ghost-ignition').debug('utils:image-size-cache'),
Promise = require('bluebird'),
imageSize = require('./image-size'),
logging = require('../logging'),
errors = require('../errors'),
@ -22,6 +23,8 @@ function getCachedImageSizeFromUrl(url) {
return imageSize.getImageSizeFromUrl(url).then(function (res) {
imageSizeCache[url] = res;
debug('Cached image:', url);
return Promise.resolve(imageSizeCache[url]);
}).catch(errors.NotFoundError, function () {
// in case of error we just attach the url
@ -33,6 +36,7 @@ function getCachedImageSizeFromUrl(url) {
return Promise.resolve(imageSizeCache[url] = url);
});
}
debug('Read image from cache:', url);
// returns image size from cache
return Promise.resolve(imageSizeCache[url]);
}

7
core/server/utils/image-size.js
View File

@ -1,4 +1,5 @@
var sizeOf = require('image-size'),
var debug = require('ghost-ignition').debug('utils:image-size'),
sizeOf = require('image-size'),
url = require('url'),
Promise = require('bluebird'),
got = require('got'),
@ -114,6 +115,8 @@ getImageSizeFromUrl = function getImageSizeFromUrl(imagePath) {
imagePath,
requestOptions
).then(function (response) {
debug('Image fetched (URL):', imagePath.href);
return fetchDimensionsFromBuffer({
buffer: response.body,
imagePath: imagePath.href
@ -170,6 +173,8 @@ getImageSizeFromFilePath = function getImageSizeFromFilePath(imagePath) {
return storage.getStorage()
.read({path: imagePath})
.then(function readFile(buf) {
debug('Image fetched (storage):', imagePath);
return fetchDimensionsFromBuffer({
buffer: buf,
imagePath: imagePath