TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-03 08:25:06 +03:00
Code Issues Projects Releases Wiki Activity

Removed use of 'routes' parameter for getCurrentHash function

Browse Source 
refs https://linear.app/tryghost/issue/CORE-35/refactor-route-and-redirect-settings

- With a single possible value for setting ('routes') there's no need to pass the parameter around
This commit is contained in:
Naz 2021-09-23 14:31:58 +02:00 committed by naz
parent 748ea9540c
commit 58ba14c188
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/boot.js
View File

@ -155,7 +155,7 @@ async function initDynamicRouting() {
debug(`Frontend API Version: ${apiVersion}`);
routing.bootstrap.start(apiVersion, routeSettings);
const getRoutesHash = () => frontendSettings.getCurrentHash('routes');
const getRoutesHash = () => frontendSettings.getCurrentHash();
const settings = require('./server/services/settings');
await settings.syncRoutesHash(getRoutesHash);

4
core/frontend/services/settings/index.js
View File

@ -38,8 +38,8 @@ module.exports = {
return defaultRoutesSettingHash;
},
getCurrentHash: async (setting) => {
const data = await SettingsLoader.loadSettings(setting);
getCurrentHash: async () => {
const data = await SettingsLoader.loadSettings('routes');
return calculateHash(JSON.stringify(data));
}

2
core/server/api/canary/settings.js
View File

@ -191,7 +191,7 @@ module.exports = {
},
async query(frame) {
await routeSettings.setFromFilePath(frame.file.path);
const getRoutesHash = () => frontendSettings.getCurrentHash('routes');
const getRoutesHash = () => frontendSettings.getCurrentHash();
await settingsService.syncRoutesHash(getRoutesHash);
}
},

2
core/server/api/v2/settings.js
View File

@ -169,7 +169,7 @@ module.exports = {
},
async query(frame) {
await routeSettings.setFromFilePath(frame.file.path);
const getRoutesHash = () => frontendSettings.getCurrentHash('routes');
const getRoutesHash = () => frontendSettings.getCurrentHash();
await settingsService.syncRoutesHash(getRoutesHash);
}
},

2
core/server/api/v3/settings.js
View File

@ -195,7 +195,7 @@ module.exports = {
},
async query(frame) {
await routeSettings.setFromFilePath(frame.file.path);
const getRoutesHash = () => frontendSettings.getCurrentHash('routes');
const getRoutesHash = () => frontendSettings.getCurrentHash();
await settingsService.syncRoutesHash(getRoutesHash);
}
},