TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-25 20:03:12 +03:00
Code Issues Projects Releases Wiki Activity

Required no active subscriptions when modifying products

Browse Source 
refs https://github.com/TryGhost/Team/issues/748

This ensures that a member cannot be attached to a product directly if
they have active subscriptions.
This commit is contained in:
Fabien O'Carroll 2021-06-15 12:41:47 +01:00 committed by Fabien 'egg' O'Carroll
parent 9079a9b9e0
commit 5ad0c624e3
1 changed files with 1 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
ghost/members-api/lib/repositories/member/index.js
View File

@ -129,28 +129,7 @@ module.exports = class MemberRepository {
}); });
if (existingActiveSubscriptions.length) { if (existingActiveSubscriptions.length) {
const memberWithSubscriptions = await this._Member.findOne({ throw new Error('Cannot edit products for a Member who has a subscription');
id: options.id
}, {
...sharedOptions,
withRelated: ['stripeSubscriptions', 'stripeSubscriptions.stripePrice', 'stripeSubscriptions.stripePrice.stripeProduct']
});
const productsDueToSubscriptions = memberWithSubscriptions.related('stripeSubscriptions').reduce((products, subscription) => {
if (!this.isActiveSubscriptionStatus(subscription.get('status'))) {
return products;
}
return products.concat(subscription.related('stripePrice').related('stripeProduct').get('product_id'));
}, []);
const productsToModify = productsToAdd.concat(productsToRemove);
const attemptingToModifyASubscriptionsProduct = productsDueToSubscriptions.some((id) => productsToModify.includes(id));
if (attemptingToModifyASubscriptionsProduct) {
throw new Error('Cannot edit products for which a Member has a subscription');
}
} }
} }
} }