TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-03 16:38:22 +03:00
Code Issues Projects Releases Wiki Activity

Checked boot preconditions in members service init

Browse Source 
refs https://github.com/TryGhost/Team/issues/598

We now have several pre-conditions related to members which determine
whether or not Ghost is allowed to start. Rather than burying this
within the members-api module, we have now surfaced them to an init
method which can be called during the boot sequence of Ghost. This will
allow us to exit early and explicitly.
This commit is contained in:
Fabien O'Carroll 2021-05-12 13:46:05 +01:00
parent 3f6544bebc
commit 5cdf910e63
1 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
core/server/services/members/service.js
View File

@ -60,6 +60,25 @@ events.on('settings.edited', function updateSettingFromModel(settingModel) {
});
const membersService = {
async init() {
const env = config.get('env');
const paymentConfig = membersConfig.getStripePaymentConfig();
if (env !== 'production') {
if (!process.env.WEBHOOK_SECRET && membersConfig.isStripeConnected()) {
throw new Error('Cannot use remote webhooks in development. Please restart in production mode or see https://ghost.org/docs/webhooks/#stripe-webhooks for developing with Stripe.');
}
if (paymentConfig && paymentConfig.secretKey.startsWith('sk_live')) {
throw new Error('Cannot use live stripe keys in development. Please restart in production mode.');
}
} else {
const siteUrl = urlUtils.getSiteUrl();
if (!/^https/.test(siteUrl)) {
throw new Error('Cannot run Ghost without SSL when Stripe is connected. Please update your url config to use "https://"');
}
}
},
contentGating: require('./content-gating'),
config: membersConfig,
@ -70,9 +89,6 @@ const membersService = {
membersApi.bus.on('error', function (err) {
logging.error(err);
if (err.fatal) {
process.exit(1);
}
});
}
return membersApi;