TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-26 20:34:02 +03:00
Code Issues Projects Releases Wiki Activity

🎨 Increased allowed lengths of tag names/slugs and user names (#905)

Browse Source 
refs TryGhost/Ghost#8143

Increases existing input validation length (soft limits) of the following fields:
   - `tags.name`: 191 chars
   - `tags.slug`: 191 chars
   - `users.name`: 191 chars
This commit is contained in:
Aileen Nowak 2017-11-09 21:31:25 +07:00 committed by Kevin Ansfield
parent dee8927418
commit 61cb95f867
4 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ghost/admin/app/validators/tag-settings.js
View File

@ -12,8 +12,8 @@ export default BaseValidator.create({
} else if (name.match(/^,/)) { } else if (name.match(/^,/)) {
model.get('errors').add('name', 'Tag names can\'t start with commas.'); model.get('errors').add('name', 'Tag names can\'t start with commas.');
this.invalidate(); this.invalidate();
} else if (!validator.isLength(name, 0, 150)) { } else if (!validator.isLength(name, 0, 191)) {
model.get('errors').add('name', 'Tag names cannot be longer than 150 characters.'); model.get('errors').add('name', 'Tag names cannot be longer than 191 characters.');
this.invalidate(); this.invalidate();
} }
}, },
@ -21,8 +21,8 @@ export default BaseValidator.create({
slug(model) { slug(model) {
let slug = model.get('slug'); let slug = model.get('slug');
if (!validator.isLength(slug, 0, 150)) { if (!validator.isLength(slug, 0, 191)) {
model.get('errors').add('slug', 'URL cannot be longer than 150 characters.'); model.get('errors').add('slug', 'URL cannot be longer than 191 characters.');
this.invalidate(); this.invalidate();
} }
}, },

2
ghost/admin/app/validators/user.js
View File

@ -15,7 +15,7 @@ export default PasswordValidator.create({
if (validator.empty(name)) { if (validator.empty(name)) {
model.get('errors').add('name', 'Please enter a name.'); model.get('errors').add('name', 'Please enter a name.');
this.invalidate(); this.invalidate();
} else if (!validator.isLength(name, 0, 150)) { } else if (!validator.isLength(name, 0, 191)) {
model.get('errors').add('name', 'Name is too long'); model.get('errors').add('name', 'Name is too long');
this.invalidate(); this.invalidate();
} }

2
ghost/admin/tests/acceptance/team-test.js
View File

@ -476,7 +476,7 @@ describe('Acceptance: Team', function () {
expect(find('.user-details-bottom .first-form-group').hasClass('error'), 'username input is in error state with blank input').to.be.true; expect(find('.user-details-bottom .first-form-group').hasClass('error'), 'username input is in error state with blank input').to.be.true;
// test too long user name // test too long user name
await fillIn('[data-test-name-input]', new Array(160).join('a')); await fillIn('[data-test-name-input]', new Array(195).join('a'));
await triggerEvent('[data-test-name-input]', 'blur'); await triggerEvent('[data-test-name-input]', 'blur');
expect(find('.user-details-bottom .first-form-group').hasClass('error'), 'username input is in error state with too long input').to.be.true; expect(find('.user-details-bottom .first-form-group').hasClass('error'), 'username input is in error state with too long input').to.be.true;

24
ghost/admin/tests/unit/validators/tag-settings-test.js
View File

@ -53,10 +53,10 @@ describe('Unit: Validator: tag-settings', function () {
it('passes with valid name', function () { it('passes with valid name', function () {
// longest valid name // longest valid name
let tag = Tag.create({name: (new Array(151).join('x'))}); let tag = Tag.create({name: (new Array(192).join('x'))});
let passed = false; let passed = false;
expect(tag.get('name').length, 'name length').to.equal(150); expect(tag.get('name').length, 'name length').to.equal(191);
run(() => { run(() => {
tag.validate({property: 'name'}).then(() => { tag.validate({property: 'name'}).then(() => {
@ -116,11 +116,11 @@ describe('Unit: Validator: tag-settings', function () {
it('validates name length', function () { it('validates name length', function () {
// shortest invalid name // shortest invalid name
let tag = Tag.create({name: (new Array(152).join('x'))}); let tag = Tag.create({name: (new Array(193).join('x'))});
let passed = false; let passed = false;
let nameErrors; let nameErrors;
expect(tag.get('name').length, 'name length').to.equal(151); expect(tag.get('name').length, 'name length').to.equal(192);
run(() => { run(() => {
tag.validate({property: 'name'}).then(() => { tag.validate({property: 'name'}).then(() => {
@ -130,7 +130,7 @@ describe('Unit: Validator: tag-settings', function () {
nameErrors = tag.get('errors').errorsFor('name')[0]; nameErrors = tag.get('errors').errorsFor('name')[0];
expect(nameErrors.attribute, 'errors.name.attribute').to.equal('name'); expect(nameErrors.attribute, 'errors.name.attribute').to.equal('name');
expect(nameErrors.message, 'errors.name.message').to.equal('Tag names cannot be longer than 150 characters.'); expect(nameErrors.message, 'errors.name.message').to.equal('Tag names cannot be longer than 191 characters.');
expect(passed, 'passed').to.be.false; expect(passed, 'passed').to.be.false;
expect(tag.get('hasValidated'), 'hasValidated').to.include('name'); expect(tag.get('hasValidated'), 'hasValidated').to.include('name');
@ -138,10 +138,10 @@ describe('Unit: Validator: tag-settings', function () {
it('passes with valid slug', function () { it('passes with valid slug', function () {
// longest valid slug // longest valid slug
let tag = Tag.create({slug: (new Array(151).join('x'))}); let tag = Tag.create({slug: (new Array(192).join('x'))});
let passed = false; let passed = false;
expect(tag.get('slug').length, 'slug length').to.equal(150); expect(tag.get('slug').length, 'slug length').to.equal(191);
run(() => { run(() => {
tag.validate({property: 'slug'}).then(() => { tag.validate({property: 'slug'}).then(() => {
@ -155,11 +155,11 @@ describe('Unit: Validator: tag-settings', function () {
it('validates slug length', function () { it('validates slug length', function () {
// shortest invalid slug // shortest invalid slug
let tag = Tag.create({slug: (new Array(152).join('x'))}); let tag = Tag.create({slug: (new Array(193).join('x'))});
let passed = false; let passed = false;
let slugErrors; let slugErrors;
expect(tag.get('slug').length, 'slug length').to.equal(151); expect(tag.get('slug').length, 'slug length').to.equal(192);
run(() => { run(() => {
tag.validate({property: 'slug'}).then(() => { tag.validate({property: 'slug'}).then(() => {
@ -169,7 +169,7 @@ describe('Unit: Validator: tag-settings', function () {
slugErrors = tag.get('errors').errorsFor('slug')[0]; slugErrors = tag.get('errors').errorsFor('slug')[0];
expect(slugErrors.attribute, 'errors.slug.attribute').to.equal('slug'); expect(slugErrors.attribute, 'errors.slug.attribute').to.equal('slug');
expect(slugErrors.message, 'errors.slug.message').to.equal('URL cannot be longer than 150 characters.'); expect(slugErrors.message, 'errors.slug.message').to.equal('URL cannot be longer than 191 characters.');
expect(passed, 'passed').to.be.false; expect(passed, 'passed').to.be.false;
expect(tag.get('hasValidated'), 'hasValidated').to.include('slug'); expect(tag.get('hasValidated'), 'hasValidated').to.include('slug');
@ -177,10 +177,10 @@ describe('Unit: Validator: tag-settings', function () {
it('passes with a valid description', function () { it('passes with a valid description', function () {
// longest valid description // longest valid description
let tag = Tag.create({description: (new Array(201).join('x'))}); let tag = Tag.create({description: (new Array(501).join('x'))});
let passed = false; let passed = false;
expect(tag.get('description').length, 'description length').to.equal(200); expect(tag.get('description').length, 'description length').to.equal(500);
run(() => { run(() => {
tag.validate({property: 'description'}).then(() => { tag.validate({property: 'description'}).then(() => {