TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-18 07:51:55 +03:00
Code Issues Projects Releases Wiki Activity

Removed Sentry message on successful Lexical save (#20362)

Browse Source 
fixes https://linear.app/tryghost/issue/SLO-147

- removed Sentry message when the Lexical save is slow but successful
- bumped Sentry message to error level when the Lexical is slow and
fails
This commit is contained in:
Sag 2024-06-11 12:17:21 +02:00 committed by GitHub
parent f454aed9c9
commit 63c674828a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ghost/admin/app/controllers/lexical-editor.js
View File

@ -16,7 +16,6 @@ import {GENERIC_ERROR_MESSAGE} from '../services/notifications';
import {action, computed} from '@ember/object'; import {action, computed} from '@ember/object';
import {alias, mapBy} from '@ember/object/computed'; import {alias, mapBy} from '@ember/object/computed';
import {capitalizeFirstLetter} from '../helpers/capitalize-first-letter'; import {capitalizeFirstLetter} from '../helpers/capitalize-first-letter';
import {captureMessage} from '@sentry/ember';
import {dropTask, enqueueTask, restartableTask, task, taskGroup, timeout} from 'ember-concurrency'; import {dropTask, enqueueTask, restartableTask, task, taskGroup, timeout} from 'ember-concurrency';
import {htmlSafe} from '@ember/template'; import {htmlSafe} from '@ember/template';
import {inject} from 'ghost-admin/decorators/inject'; import {inject} from 'ghost-admin/decorators/inject';
@ -793,22 +792,11 @@ export default class LexicalEditorController extends Controller {
try { try {
yield post.save(options); yield post.save(options);
// log if a save is slow
if (this.config.sentry_dsn && (Date.now() - startTime > 2000)) {
captureMessage('Successful Lexical save took > 2s', (scope) => {
scope.setTag('save_time', Math.ceil((Date.now() - startTime) / 1000));
scope.setTag('post_type', post.isPage ? 'page' : 'post');
scope.setTag('save_revision', options.adapterOptions?.saveRevision);
scope.setTag('email_segment', options.adapterOptions?.emailSegment);
scope.setTag('convert_to_lexical', options.adapterOptions?.convertToLexical);
});
}
} catch (error) { } catch (error) {
this.post.set('emailOnly', previousEmailOnlyValue); this.post.set('emailOnly', previousEmailOnlyValue);
if (this.config.sentry_dsn && (Date.now() - startTime > 2000)) { if (this.config.sentry_dsn && (Date.now() - startTime > 2000)) {
captureMessage('Failed Lexical save took > 2s', (scope) => { Sentry.captureException('Failed Lexical save took > 2s', (scope) => {
scope.setTag('save_time', Math.ceil((Date.now() - startTime) / 1000)); scope.setTag('save_time', Math.ceil((Date.now() - startTime) / 1000));
scope.setTag('post_type', post.isPage ? 'page' : 'post'); scope.setTag('post_type', post.isPage ? 'page' : 'post');
scope.setTag('save_revision', options.adapterOptions?.saveRevision); scope.setTag('save_revision', options.adapterOptions?.saveRevision);