TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-24 14:43:08 +03:00
Code Issues Projects Releases Wiki Activity

Updated post links in member event feeds to point to post analytics screen (#16384)

Browse Source 
refs https://github.com/TryGhost/Team/issues/2612

- member event feeds previously had links to posts that opened the
front-end post URL in a new tab
- now that we have an analytics screen for each post it makes sense to
link to that screen where possible because it allows drill-down into
site performance
This commit is contained in:
Kevin Ansfield 2023-03-15 07:12:16 +00:00 committed by GitHub
parent a7207eb0dd
commit 6a3a4632ad
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 41 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ghost/admin/app/components/dashboard/charts/recents.hbs
View File

@ -104,7 +104,10 @@
{{#if parsedEvent.info}}
<span class="highlight">({{parsedEvent.info}})</span>
{{/if}}
{{#if parsedEvent.url}}
{{#if parsedEvent.route}}
<span class="gh-members-activity-event-join">{{parsedEvent.join}}</span>
<LinkTo class="gh-members-activity-object-link" @route={{parsedEvent.route.name}} @model={{parsedEvent.route.model}}>{{parsedEvent.object}}</LinkTo>
{{else if parsedEvent.url}}
<span class="gh-members-activity-event-join">{{parsedEvent.join}}</span>
<a class="ghost-members-activity-object-link" href="{{parsedEvent.url}}" target="_blank" rel="noopener noreferrer">{{parsedEvent.object}}</a>
{{else if parsedEvent.email}}

5
ghost/admin/app/components/member/activity-feed.hbs
View File

@ -29,7 +29,10 @@
{{#if event.info}}
<span class="highlight">({{event.info}})</span>
{{/if}}
{{#if event.url}}
{{#if event.route}}
<span class="gh-members-activity-event-join">{{event.join}}</span>
<LinkTo class="gh-members-activity-object-link" @route={{event.route.name}} @model={{event.route.model}}>{{event.object}}</LinkTo>
{{else if event.url}}
<span class="gh-members-activity-event-join">{{event.join}}</span>
<a class="ghost-members-activity-object-link" href="{{event.url}}" target="_blank" rel="noopener noreferrer">{{event.object}}</a>
{{else if event.email}}

7
ghost/admin/app/components/members-activity/table-row.hbs
View File

@ -1,5 +1,5 @@
{{#let (parse-member-event @event @hasMultipleNewsletters) as |event|}}
<tr>
<tr>
{{#unless @hideMemberColumn}}
<div class="gh-list-data">
<LinkTo @route="members-activity" @query={{hash member=event.member.id}}>
@ -24,7 +24,10 @@
{{#if event.info}}
<span class="highlight">({{event.info}})</span>
{{/if}}
{{#if event.url}}
{{#if event.route}}
<span class="gh-members-activity-event-join">{{event.join}}</span>
<LinkTo class="gh-members-activity-object-link" @route={{event.route.name}} @model={{event.route.model}}>{{event.object}}</LinkTo>
{{else if event.url}}
<span class="gh-members-activity-event-join">{{event.join}}</span>
<a class="ghost-members-activity-object-link" href="{{event.url}}" target="_blank" rel="noopener noreferrer">{{event.object}}</a>
{{else if event.email}}

30
ghost/admin/app/helpers/parse-member-event.js
View File

@ -19,6 +19,7 @@ export default class ParseMemberEventHelper extends Helper {
const join = this.getJoin(event);
const object = this.getObject(event);
const url = this.getURL(event);
const route = this.getRoute(event);
const timestamp = moment(event.data.created_at);
const source = this.getSource(event);
@ -36,6 +37,7 @@ export default class ParseMemberEventHelper extends Helper {
info,
description,
url,
route,
timestamp
};
}
@ -308,17 +310,41 @@ export default class ParseMemberEventHelper extends Helper {
* Make the object clickable
*/
getURL(event) {
if (event.type === 'comment_event' || event.type === 'click_event' || event.type === 'feedback_event') {
if (['comment_event', 'click_event', 'feedback_event'].includes(event.type)) {
if (event.data.post) {
return event.data.post.url;
}
}
if (event.type === 'signup_event' || event.type === 'subscription_event') {
if (['signup_event', 'subscription_event'].includes(event.type)) {
if (event.data.attribution && event.data.attribution.url) {
return event.data.attribution.url;
}
}
return;
}
/**
* Get internal route props for a clickable object
*/
getRoute(event) {
if (['comment_event', 'click_event', 'feedback_event'].includes(event.type)) {
if (event.data.post) {
return {
name: 'posts.analytics',
model: event.data.post.id
};
}
}
if (['signup_event', 'subscription_event'].includes(event.type)) {
if (event.data.attribution_type === 'post') {
return {
name: 'posts.analytics',
model: event.data.attribution_id
};
}
}
return;
}
}