TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-28 05:37:34 +03:00
Code Issues Projects Releases Wiki Activity

Add attributes for {{tags}} and {{#foreach}} helpers

Browse Source 
issue #6205
- added `from` and `to` attribute for `{{tags}}` and `{{#foreach}}` helpers.
- added tests for these new atttributes
This commit is contained in:
Szu Yaung 2015-12-30 01:52:13 +08:00
parent 000d3a100f
commit 70327c2a74
4 changed files with 129 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
core/server/helpers/foreach.js
View File

@ -19,6 +19,8 @@ foreach = function (context, options) {
columns = options.hash.columns,
length = _.size(context),
limit = parseInt(options.hash.limit, 10) || length,
from = parseInt(options.hash.from, 10) || 1,
to = parseInt(options.hash.to, 10) || (from - 1) + limit,
output = '',
data,
contextPath;
@ -40,7 +42,7 @@ foreach = function (context, options) {
data.key = field;
data.index = index;
data.number = index + 1;
data.first = index === 0;
data.first = index === from - 1; // From uses 1-indexed, but array uses 0-indexed.
data.last = !!last;
data.even = index % 2 === 1;
data.odd = !data.even;
@ -59,13 +61,20 @@ foreach = function (context, options) {
}
function iterateCollection(context) {
var count = 1;
var count = 1,
current = 1;
_.each(context, function (item, key) {
if (count <= limit) {
execIteration(key, count - 1, count === limit);
if (current < from) {
current += 1;
return;
}
if (current <= to) {
execIteration(key, current - 1, current === to);
}
count += 1;
current += 1;
});
}

10
core/server/helpers/tags.js
View File

@ -21,6 +21,8 @@ tags = function (options) {
prefix = _.isString(options.hash.prefix) ? options.hash.prefix : '',
suffix = _.isString(options.hash.suffix) ? options.hash.suffix : '',
limit = options.hash.limit ? parseInt(options.hash.limit, 10) : undefined,
from = options.hash.from ? parseInt(options.hash.from, 10) : 1,
to = options.hash.to ? parseInt(options.hash.to, 10) : undefined,
output = '';
function createTagList(tags) {
@ -37,12 +39,10 @@ tags = function (options) {
if (this.tags && this.tags.length) {
output = createTagList(this.tags);
from -= 1; // From uses 1-indexed, but array uses 0-indexed.
to = to || limit + from || this.tags.length;
if (limit) {
output = output.slice(0, limit);
}
output = prefix + output.join(separator) + suffix;
output = prefix + output.slice(from, to).join(separator) + suffix;
}
return new hbs.handlebars.SafeString(output);

56
core/test/unit/server_helpers/foreach_spec.js
View File

@ -378,5 +378,61 @@ describe('{{#foreach}} helper', function () {
shouldCompileToExpected(templateString, arrayHash, expected);
shouldCompileToExpected(templateString, objectHash, expected);
});
it('foreach with from 2', function () {
var templateString = '<ul>{{#foreach posts from="2"}}<li>{{title}}</li>{{else}}not this{{/foreach}}</ul>',
expected = '<ul><li>second</li><li>third</li><li>fourth</li><li>fifth</li></ul>';
shouldCompileToExpected(templateString, arrayHash, expected);
shouldCompileToExpected(templateString, objectHash, expected);
});
it('foreach with to 4', function () {
var templateString = '<ul>{{#foreach posts to="4"}}<li>{{title}}</li>{{else}}not this{{/foreach}}</ul>',
expected = '<ul><li>first</li><li>second</li><li>third</li><li>fourth</li></ul>';
shouldCompileToExpected(templateString, arrayHash, expected);
shouldCompileToExpected(templateString, objectHash, expected);
});
it('foreach with from 2 and to 3', function () {
var templateString = '<ul>{{#foreach posts from="2" to="3"}}<li>{{title}}</li>{{else}}not this{{/foreach}}</ul>',
expected = '<ul><li>second</li><li>third</li></ul>';
shouldCompileToExpected(templateString, arrayHash, expected);
shouldCompileToExpected(templateString, objectHash, expected);
});
it('foreach with from 3 and limit 2', function () {
var templateString = '<ul>{{#foreach posts from="3" limit="2"}}<li>{{title}}</li>{{else}}not this{{/foreach}}</ul>',
expected = '<ul><li>third</li><li>fourth</li></ul>';
shouldCompileToExpected(templateString, arrayHash, expected);
shouldCompileToExpected(templateString, objectHash, expected);
});
it('foreach with from 2, to 5 and limit 3', function () {
var templateString = '<ul>{{#foreach posts from="2" to="5" limit="3"}}<li>{{title}}</li>{{else}}not this{{/foreach}}</ul>',
expected = '<ul><li>second</li><li>third</li><li>fourth</li><li>fifth</li></ul>';
shouldCompileToExpected(templateString, arrayHash, expected);
shouldCompileToExpected(templateString, objectHash, expected);
});
it('@first in foreach with from 2 and to 4', function () {
var templateString = '<ul>{{#foreach posts from="2" to="4"}}{{#if @first}}<li>{{title}}</li>{{/if}}{{/foreach}}</ul>',
expected = '<ul><li>second</li></ul>';
shouldCompileToExpected(templateString, arrayHash, expected);
shouldCompileToExpected(templateString, objectHash, expected);
});
it('@last in foreach with from 2 and to 4', function () {
var templateString = '<ul>{{#foreach posts from="2" to="4"}}{{#if @last}}<li>{{title}}</li>{{/if}}{{/foreach}}</ul>',
expected = '<ul><li>fourth</li></ul>';
shouldCompileToExpected(templateString, arrayHash, expected);
shouldCompileToExpected(templateString, objectHash, expected);
});
});
});

55
core/test/unit/server_helpers/tags_spec.js
View File

@ -120,4 +120,59 @@ describe('{{tags}} helper', function () {
String(rendered).should.equal('<a href="/tag/foo-bar/">foo</a>');
});
it('can list tags from a specified no.', function () {
var tags = [{name: 'foo', slug: 'foo-bar'}, {name: 'bar', slug: 'bar'}],
rendered = helpers.tags.call(
{tags: tags},
{hash: {from: '2'}}
);
should.exist(rendered);
String(rendered).should.equal('<a href="/tag/bar/">bar</a>');
});
it('can list tags to a specified no.', function () {
var tags = [{name: 'foo', slug: 'foo-bar'}, {name: 'bar', slug: 'bar'}],
rendered = helpers.tags.call(
{tags: tags},
{hash: {to: '1'}}
);
should.exist(rendered);
String(rendered).should.equal('<a href="/tag/foo-bar/">foo</a>');
});
it('can list tags in a range', function () {
var tags = [{name: 'foo', slug: 'foo-bar'}, {name: 'bar', slug: 'bar'}, {name: 'baz', slug: 'baz'}],
rendered = helpers.tags.call(
{tags: tags},
{hash: {from: '2', to: '3'}}
);
should.exist(rendered);
String(rendered).should.equal('<a href="/tag/bar/">bar</a>, <a href="/tag/baz/">baz</a>');
});
it('can limit no. tags and output from 2', function () {
var tags = [{name: 'foo', slug: 'foo-bar'}, {name: 'bar', slug: 'bar'}, {name: 'baz', slug: 'baz'}],
rendered = helpers.tags.call(
{tags: tags},
{hash: {from: '2', limit: '1'}}
);
should.exist(rendered);
String(rendered).should.equal('<a href="/tag/bar/">bar</a>');
});
it('can list tags in a range (ignore limit)', function () {
var tags = [{name: 'foo', slug: 'foo-bar'}, {name: 'bar', slug: 'bar'}, {name: 'baz', slug: 'baz'}],
rendered = helpers.tags.call(
{tags: tags},
{hash: {from: '1', to: '3', limit: '2'}}
);
should.exist(rendered);
String(rendered).should.equal('<a href="/tag/foo-bar/">foo</a>, <a href="/tag/bar/">bar</a>, <a href="/tag/baz/">baz</a>');
});
});