TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-25 19:48:50 +03:00
Code Issues Projects Releases Wiki Activity

🐛 Fixed slug not always updating for draft posts (#21691)

Browse Source 
ref https://linear.app/ghost/issue/ONC-548/

There have been reported cases of the editor not updating the slug for
draft posts. The logic should be as follows: for a draft post, if the
title was updated and we do not detect a custom slug, update it.

This got out of sync due to actions where the save was triggered but the
title onBlur effect (which updates the slug) was not triggered. This has
been resolved by evaluating the slug in the before save actions.
This commit is contained in:
Steve Larson 2024-11-22 18:24:17 -06:00 committed by GitHub
parent 3277da7140
commit 7083bd0628
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 23 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ghost/admin/app/controllers/lexical-editor.js
View File

@ -734,26 +734,19 @@ export default class LexicalEditorController extends Controller {
} }
@task @task
*beforeSaveTask(options = {}) { *beforeSaveTask() {
if (this.post?.isDestroyed || this.post?.isDestroying) { if (this.post?.isDestroyed || this.post?.isDestroying) {
return; return;
} }
// ensure we remove any blank cards when performing a full save if (this.post.status === 'draft') {
if (!options.backgroundSave) { if (this.post.titleScratch !== this.post.title) {
// TODO: not yet implemented in react editor yield this.generateSlugTask.perform();
// if (this._koenig) { }
// this._koenig.cleanup();
// this.set('hasDirtyAttributes', true);
// }
} }
// Set the properties that are indirected
// Set lexical equal to what's in the editor
this.set('post.lexical', this.post.lexicalScratch || null); this.set('post.lexical', this.post.lexicalScratch || null);
// Set a default title
if (!this.post.titleScratch?.trim()) { if (!this.post.titleScratch?.trim()) {
this.set('post.titleScratch', DEFAULT_TITLE); this.set('post.titleScratch', DEFAULT_TITLE);
} }
@ -774,7 +767,6 @@ export default class LexicalEditorController extends Controller {
if (!this.get('post.slug')) { if (!this.get('post.slug')) {
this.saveTitleTask.cancelAll(); this.saveTitleTask.cancelAll();
yield this.generateSlugTask.perform(); yield this.generateSlugTask.perform();
} }
} }

18
ghost/admin/tests/acceptance/editor-test.js
View File

@ -623,6 +623,24 @@ describe('Acceptance: Editor', function () {
expect(find('[data-test-editor-post-status]')).to.contain.text('New'); expect(find('[data-test-editor-post-status]')).to.contain.text('New');
}); });
it('updates slug when title changes without blur', async function () {
let post = this.server.create('post', {authors: [author]});
await visit(`/editor/post/${post.id}`);
await fillIn('[data-test-editor-title-input]', 'Test Title');
await triggerEvent('[data-test-editor-title-input]', 'keydown', {
keyCode: 83, // s
metaKey: ctrlOrCmd === 'command',
ctrlKey: ctrlOrCmd === 'ctrl'
});
let [lastRequest] = this.server.pretender.handledRequests.slice(-1);
let body = JSON.parse(lastRequest.requestBody);
expect(body.posts[0].slug).to.equal('test-title');
expect(post.slug).to.equal('test-title');
});
it('handles TKs in title', async function () { it('handles TKs in title', async function () {
let post = this.server.create('post', {authors: [author]}); let post = this.server.create('post', {authors: [author]});