TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-27 18:52:14 +03:00
Code Issues Projects Releases Wiki Activity

Fixed generating duplicate newsletter names

Browse Source 
refs https://github.com/TryGhost/DevOps/issues/119

- this switches away from using a static list of names in favor of ones
  generated by faker, so we don't run into duplicate names
- also minor code re-arranging
This commit is contained in:
Daniel Lockyer 2023-12-07 12:18:49 +01:00 committed by Daniel Lockyer
parent 8197a740b1
commit 739c690a29
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ghost/data-generator/lib/importers/NewslettersImporter.js
View File

@ -6,21 +6,23 @@ const {slugify} = require('@tryghost/string');
class NewslettersImporter extends TableImporter { class NewslettersImporter extends TableImporter {
static table = 'newsletters'; static table = 'newsletters';
static dependencies = []; static dependencies = [];
defaultQuantity = 2; defaultQuantity = 2;
sortOrder = 0;
constructor(knex, transaction) { constructor(knex, transaction) {
super(NewslettersImporter.table, knex, transaction); super(NewslettersImporter.table, knex, transaction);
this.sortOrder = 0;
// TODO: Use random names if we ever need more than 2 newsletters
this.names = ['Regular premium', 'Occasional freebie'];
} }
generate() { generate() {
const name = this.names.shift(); const name = `${faker.commerce.productAdjective()} ${faker.word.noun()}`;
const sortOrder = this.sortOrder; const sortOrder = this.sortOrder;
this.sortOrder = this.sortOrder + 1; this.sortOrder = this.sortOrder + 1;
const weekAfter = new Date(blogStartDate); const weekAfter = new Date(blogStartDate);
weekAfter.setDate(weekAfter.getDate() + 7); weekAfter.setDate(weekAfter.getDate() + 7);
return { return {
id: faker.database.mongodbObjectId(), id: faker.database.mongodbObjectId(),
uuid: faker.datatype.uuid(), uuid: faker.datatype.uuid(),