TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-25 03:44:29 +03:00
Code Issues Projects Releases Wiki Activity

Cleaned up onValidate method on settings model

Browse Source 
no-issue

Explicit arguments and async/await make this nicer on the eyes
This commit is contained in:
Fabien O'Carroll 2020-06-30 16:39:37 +02:00 committed by Fabien 'egg' O'Carroll
parent dd270b399c
commit 774187ced5
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
core/server/models/settings.js
View File

@ -122,13 +122,9 @@ Settings = ghostBookshelf.Model.extend({
model.emitChange(model.attributes.key + '.' + 'edited', options);
},
onValidate: function onValidate() {
const self = this;
return ghostBookshelf.Model.prototype.onValidate.apply(this, arguments)
.then(function then() {
return validation.validateSettings(getDefaultSettings(), self);
});
async onValidate(model, attr, options) {
await ghostBookshelf.Model.prototype.onValidate.call(this, model, attr, options);
await validation.validateSettings(getDefaultSettings(), model);
},
format() {