TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-24 03:14:03 +03:00
Code Issues Projects Releases Wiki Activity

🐛 Fixed outboundLinkTagging setting affected whether member sources are tracked (#18498)

Browse Source 
no issue

- During the one click subscribe flow, the outboundLinkTagging should
affect whether we send a history or not to the signup endpoint. But for
internal history this is the members_track_sources setting. This happens
in the backend normally.
- Do not send a (constructed) history to external sites (= one click
subscribe flow in recommendations) if outboundLinkTagging is false
- Do always send a history internally for local signups (backend handles
whether to store it based on the members_track_sources setting that is
currently not exposed in the frontend). The history is not built if this
setting is disabled, but we could have an old history entry if this
setting was enabled in the past.
This commit is contained in:
Simon Backx 2023-10-05 12:25:21 +02:00 committed by GitHub
parent 85098e07d4
commit 7b3a0c6863
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
apps/portal/src/actions.js
View File

@ -79,7 +79,7 @@ async function signout({api, state}) {
async function signin({data, api, state}) {
try {
await api.member.sendMagicLink({...data, emailType: 'signin', outboundLinkTagging: state.site.outbound_link_tagging});
await api.member.sendMagicLink({...data, emailType: 'signin'});
return {
page: 'magiclink',
lastPage: 'signin'
@ -100,7 +100,7 @@ async function signup({data, state, api}) {
let {plan, tierId, cadence, email, name, newsletters, offerId} = data;
if (plan.toLowerCase() === 'free') {
await api.member.sendMagicLink({emailType: 'signup', ...data, outboundLinkTagging: state.site.outbound_link_tagging});
await api.member.sendMagicLink({emailType: 'signup', ...data});
} else {
if (tierId && cadence) {
await api.member.checkoutPlan({plan, tierId, cadence, email, name, newsletters, offerId});
@ -487,15 +487,14 @@ async function oneClickSubscribe({data: {siteUrl}, state}) {
name: member.name,
email: member.email,
autoRedirect: false,
outboundLinkTagging: state.site.outbound_link_tagging,
customUrlHistory: [
customUrlHistory: state.site.outbound_link_tagging ? [
{
time: Date.now(),
referrerSource,
referrerMedium: 'Ghost Recommendations',
referrerUrl
}
]
] : []
});
return {};

4
apps/portal/src/utils/api.js
View File

@ -243,7 +243,7 @@ function setupGhostApi({siteUrl = window.location.origin, apiUrl, apiKey}) {
});
},
async sendMagicLink({email, emailType, labels, name, oldEmail, newsletters, redirect, customUrlHistory, outboundLinkTagging, autoRedirect = true}) {
async sendMagicLink({email, emailType, labels, name, oldEmail, newsletters, redirect, customUrlHistory, autoRedirect = true}) {
const url = endpointFor({type: 'members', resource: 'send-magic-link'});
const body = {
name,
@ -257,7 +257,7 @@ function setupGhostApi({siteUrl = window.location.origin, apiUrl, apiKey}) {
autoRedirect
};
const urlHistory = customUrlHistory ?? getUrlHistory();
if (urlHistory && outboundLinkTagging) {
if (urlHistory) {
body.urlHistory = urlHistory;
}