From 85d1775608846ddc4daeb34355a0577edd007a97 Mon Sep 17 00:00:00 2001
From: Rish <zrishabhgarg@gmail.com>
Date: Thu, 4 Jun 2020 19:16:52 +0530
Subject: [PATCH] Removed redundant reset value for task buttons

no issue

- Since task buttons by default have reset on now, we don't need to explicitly add it to individual buttons
---
 ghost/admin/app/components/gh-post-settings-menu/email.hbs   | 1 -
 ghost/admin/app/components/gh-publishmenu.hbs                | 1 -
 ghost/admin/app/components/modal-custom-view-form.hbs        | 1 -
 ghost/admin/app/components/modal-impersonate-member.hbs      | 2 --
 ghost/admin/app/components/modal-members-label-form.hbs      | 1 -
 ghost/admin/app/templates/member.hbs                         | 2 +-
 ghost/admin/app/templates/settings/code-injection.hbs        | 2 +-
 ghost/admin/app/templates/settings/design.hbs                | 2 +-
 ghost/admin/app/templates/settings/general.hbs               | 2 +-
 ghost/admin/app/templates/settings/integration.hbs           | 2 +-
 ghost/admin/app/templates/settings/integrations/slack.hbs    | 2 +-
 ghost/admin/app/templates/settings/integrations/unsplash.hbs | 2 +-
 ghost/admin/app/templates/settings/labs.hbs                  | 1 -
 ghost/admin/app/templates/tag.hbs                            | 2 +-
 14 files changed, 8 insertions(+), 15 deletions(-)

diff --git a/ghost/admin/app/components/gh-post-settings-menu/email.hbs b/ghost/admin/app/components/gh-post-settings-menu/email.hbs
index 5829b3bded..b26e0af596 100644
--- a/ghost/admin/app/components/gh-post-settings-menu/email.hbs
+++ b/ghost/admin/app/components/gh-post-settings-menu/email.hbs
@@ -138,7 +138,6 @@
                     {{/if}}
 
                     <GhTaskButton @buttonText="Send test email"
-                        @autoReset={{true}}
                         @task={{this.sendTestEmail}}
                         @successText="Email sent"
                         @runningText="Sending..."
diff --git a/ghost/admin/app/components/gh-publishmenu.hbs b/ghost/admin/app/components/gh-publishmenu.hbs
index a51ff20837..e5cb86a35c 100644
--- a/ghost/admin/app/components/gh-publishmenu.hbs
+++ b/ghost/admin/app/components/gh-publishmenu.hbs
@@ -45,7 +45,6 @@
                 @taskArgs={{hash dropdown=dd}}
                 @successText={{this.successText}}
                 @runningText={{this.runningText}}
-                @autoReset={{true}}
                 @class="gh-btn gh-btn-blue gh-publishmenu-button gh-btn-icon"
                 data-test-publishmenu-save=true
             />
diff --git a/ghost/admin/app/components/modal-custom-view-form.hbs b/ghost/admin/app/components/modal-custom-view-form.hbs
index 3d49bc138a..0277eea381 100644
--- a/ghost/admin/app/components/modal-custom-view-form.hbs
+++ b/ghost/admin/app/components/modal-custom-view-form.hbs
@@ -72,7 +72,6 @@
     <GhTaskButton
         @buttonText="Save"
         @successText="Saved"
-        @autoReset={{true}}
         @task={{this.saveTask}}
         @taskArgs={{this.model}}
         @class="gh-btn gh-btn-green gh-btn-icon"
diff --git a/ghost/admin/app/components/modal-impersonate-member.hbs b/ghost/admin/app/components/modal-impersonate-member.hbs
index 519f022e57..e6ce3b97a4 100644
--- a/ghost/admin/app/components/modal-impersonate-member.hbs
+++ b/ghost/admin/app/components/modal-impersonate-member.hbs
@@ -29,14 +29,12 @@
             />
             {{#if signinUrl}}
                 <GhTaskButton
-                @autoReset={{true}}
                 @buttonText="Copy link"
                 @task={{this.copySigninUrl}}
                 @successText="Link copied"
                 @class="gh-btn gh-btn-blue gh-btn-icon" />
             {{else}}
                 <GhTaskButton
-                @autoReset={{true}}
                 @buttonText="Copy link"
                 @task={{this.copySigninUrl}}
                 @successText="Link copied"
diff --git a/ghost/admin/app/components/modal-members-label-form.hbs b/ghost/admin/app/components/modal-members-label-form.hbs
index b02bf5f053..da9e1fb671 100644
--- a/ghost/admin/app/components/modal-members-label-form.hbs
+++ b/ghost/admin/app/components/modal-members-label-form.hbs
@@ -68,7 +68,6 @@
             @buttonText="Save"
             @runningText="Saving..."
             @successText="Saved"
-            @autoReset={{true}}
             @task={{this.saveTask}}
             @taskArgs={{this.label}}
             @class="gh-btn gh-btn-green gh-btn-icon"
diff --git a/ghost/admin/app/templates/member.hbs b/ghost/admin/app/templates/member.hbs
index 0dc2e69977..09e03a4300 100644
--- a/ghost/admin/app/templates/member.hbs
+++ b/ghost/admin/app/templates/member.hbs
@@ -21,7 +21,7 @@
                 {{/unless}}
             {{/if}}
 
-            <GhTaskButton @class="gh-btn gh-btn-blue gh-btn-icon" @type="button" @task={{this.saveTask}} @autoReset={{true}} @data-test-button="save" />
+            <GhTaskButton @class="gh-btn gh-btn-blue gh-btn-icon" @type="button" @task={{this.saveTask}} @data-test-button="save" />
         </section>
     </GhCanvasHeader>
 
diff --git a/ghost/admin/app/templates/settings/code-injection.hbs b/ghost/admin/app/templates/settings/code-injection.hbs
index 948a666a9a..9014f5fd3b 100644
--- a/ghost/admin/app/templates/settings/code-injection.hbs
+++ b/ghost/admin/app/templates/settings/code-injection.hbs
@@ -4,7 +4,7 @@
             Code injection
         </h2>
         <section class="view-actions">
-            <GhTaskButton @task={{this.saveTask}} @autoReset={{true}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button={{true}} />
+            <GhTaskButton @task={{this.saveTask}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button={{true}} />
         </section>
     </GhCanvasHeader>
 
diff --git a/ghost/admin/app/templates/settings/design.hbs b/ghost/admin/app/templates/settings/design.hbs
index 4f18f0578a..76d0cd196f 100644
--- a/ghost/admin/app/templates/settings/design.hbs
+++ b/ghost/admin/app/templates/settings/design.hbs
@@ -4,7 +4,7 @@
             Design
         </h2>
         <section class="view-actions">
-            <GhTaskButton @task={{this.save}} @autoReset={{true}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button={{true}} />
+            <GhTaskButton @task={{this.save}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button={{true}} />
         </section>
     </GhCanvasHeader>
 
diff --git a/ghost/admin/app/templates/settings/general.hbs b/ghost/admin/app/templates/settings/general.hbs
index 81886ffac2..47dadf0d7c 100644
--- a/ghost/admin/app/templates/settings/general.hbs
+++ b/ghost/admin/app/templates/settings/general.hbs
@@ -5,7 +5,7 @@
             General settings
         </h2>
         <section class="view-actions">
-            <GhTaskButton @buttonText="Save settings" @task={{this.save}} @autoReset={{true}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button="true" />
+            <GhTaskButton @buttonText="Save settings" @task={{this.save}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button="true" />
         </section>
     </GhCanvasHeader>
 
diff --git a/ghost/admin/app/templates/settings/integration.hbs b/ghost/admin/app/templates/settings/integration.hbs
index d7dada60b0..b3d851f330 100644
--- a/ghost/admin/app/templates/settings/integration.hbs
+++ b/ghost/admin/app/templates/settings/integration.hbs
@@ -7,7 +7,7 @@
                 {{this.integration.name}}
             </h2>
             <section class="view-actions">
-                <GhTaskButton @task={{this.save}} @class="gh-btn gh-btn-blue gh-btn-icon" @autoReset={{true}} data-test-button="save" />
+                <GhTaskButton @task={{this.save}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-button="save" />
             </section>
         </GhCanvasHeader>
 
diff --git a/ghost/admin/app/templates/settings/integrations/slack.hbs b/ghost/admin/app/templates/settings/integrations/slack.hbs
index 9cff67d310..38038ae30d 100644
--- a/ghost/admin/app/templates/settings/integrations/slack.hbs
+++ b/ghost/admin/app/templates/settings/integrations/slack.hbs
@@ -6,7 +6,7 @@
             Slack
         </h2>
         <section class="view-actions">
-            <GhTaskButton @task={{this.save}} @autoReset={{true}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button={{true}} />
+            <GhTaskButton @task={{this.save}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button={{true}} />
         </section>
     </GhCanvasHeader>
 
diff --git a/ghost/admin/app/templates/settings/integrations/unsplash.hbs b/ghost/admin/app/templates/settings/integrations/unsplash.hbs
index 0e84b5ca0f..9df2a990e7 100644
--- a/ghost/admin/app/templates/settings/integrations/unsplash.hbs
+++ b/ghost/admin/app/templates/settings/integrations/unsplash.hbs
@@ -6,7 +6,7 @@
             Unsplash
         </h2>
         <section class="view-actions">
-            <GhTaskButton @task={{this.save}} @autoReset={{true}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button={{true}} />
+            <GhTaskButton @task={{this.save}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button={{true}} />
         </section>
     </GhCanvasHeader>
 
diff --git a/ghost/admin/app/templates/settings/labs.hbs b/ghost/admin/app/templates/settings/labs.hbs
index d7a185e039..169766420a 100644
--- a/ghost/admin/app/templates/settings/labs.hbs
+++ b/ghost/admin/app/templates/settings/labs.hbs
@@ -35,7 +35,6 @@
                             @task={{this.saveSettings}}
                             @successText="Saved"
                             @runningText="Saving"
-                            @autoReset={{true}}
                             @class="gh-btn gh-btn-blue gh-btn-icon"
                         />
                     </div>
diff --git a/ghost/admin/app/templates/tag.hbs b/ghost/admin/app/templates/tag.hbs
index 81e6b84ed2..30fa660165 100644
--- a/ghost/admin/app/templates/tag.hbs
+++ b/ghost/admin/app/templates/tag.hbs
@@ -7,7 +7,7 @@
                 {{if this.tag.isNew "New tag" this.tag.name}}
             </h2>
             <section class="view-actions">
-                <GhTaskButton @task={{this.save}} @type="button" @class="gh-btn gh-btn-blue gh-btn-icon" @autoReset={{true}} @data-test-button="save" />
+                <GhTaskButton @task={{this.save}} @type="button" @class="gh-btn gh-btn-blue gh-btn-icon" @data-test-button="save" />
             </section>
         </GhCanvasHeader>