From 895bffec1fbc83234aa4a2e49abc0d687519f7bc Mon Sep 17 00:00:00 2001 From: Hannah Wolfe Date: Fri, 7 May 2021 19:21:15 +0100 Subject: [PATCH] Enabled no-skipped-tests eslint rule [warn] - Not sure why, but this is set to off in our base plugin - It masks issues where people have temporarily skipped tests to fix later and then forgot - Enabling this to allow us to review all those places, but we should also try to leave it on and set to error --- test/.eslintrc.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/.eslintrc.js b/test/.eslintrc.js index 55cb1e6d30..1b371e0ce0 100644 --- a/test/.eslintrc.js +++ b/test/.eslintrc.js @@ -23,6 +23,8 @@ module.exports = { 'no-unused-vars': 'off', 'no-useless-escape': 'off', + 'ghost/mocha/no-skipped-tests': 'warn', + // TODO: remove these custom rules and fix problems in test files 'ghost/mocha/max-top-level-suites': 'off', 'ghost/mocha/no-identical-title': 'off',