TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-05 18:34:39 +03:00
Code Issues Projects Releases Wiki Activity

Fix error in generating absolute URLs for RSS

Browse Source 
Closes #4886
This commit is contained in:
Jason Williams 2015-02-03 20:50:29 +00:00
parent 5af941d2c0
commit 921f7dab5b
1 changed files with 42 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
core/server/controllers/frontend.js
View File

@ -513,11 +513,51 @@ frontendControllers = {
// convert relative resource urls to absolute
['href', 'src'].forEach(function (attributeName) {
htmlContent('[' + attributeName + ']').each(function (ix, el) {
var baseUrl,
attributeValue,
parsed;
el = htmlContent(el);
var attributeValue = el.attr(attributeName);
attributeValue = url.resolve(siteUrl, attributeValue);
attributeValue = el.attr(attributeName);
// if URL is absolute move on to the next element
try {
parsed = url.parse(attributeValue);
if (parsed.protocol) {
return;
}
} catch (e) {
return;
}
// compose an absolute URL
// if the relative URL begins with a '/' use the blog URL (including sub-directory)
// as the base URL, otherwise use the post's URL.
baseUrl = attributeValue[0] === '/' ? siteUrl : item.url;
// prevent double slashes
if (baseUrl.slice(-1) === '/' && attributeValue[0] === '/') {
attributeValue = attributeValue.substr(1);
}
// make sure URL has a trailing slash
try {
parsed = url.parse(attributeValue);
if (parsed.pathname && parsed.pathname.slice(-1) !== '/') {
parsed.pathname += '/';
attributeValue = url.format(parsed);
}
} catch (e) {
// if the URL we've built cannot be parsed, fall back to the unprocessed URL
return;
}
attributeValue = baseUrl + attributeValue;
el.attr(attributeName, attributeValue);
});
});