TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-28 21:33:24 +03:00
Code Issues Projects Releases Wiki Activity

🐛 Fixed facebook/twitter images having relative URLS in API output

Browse Source 
no issue

Output serializer's url util was expecting `og_image` and `twitter_image` to be top-level attributes in the `attrs` object but they are actually nested under `posts_meta`.

- updated the code to use lodash's `get/set()` so that we can work with paths for easier handling of nested objects
- fixed unit tests where the mocked data under test did not match real-world data
This commit is contained in:
Kevin Ansfield 2020-06-30 14:27:03 +01:00 committed by Daniel Lockyer
parent 58ac033b97
commit 9810c41dca
5 changed files with 20 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
core/server/api/canary/utils/serializers/output/utils/url.js
View File

@ -46,9 +46,10 @@ const forPost = (id, attrs, frame) => {
}
});
['feature_image', 'og_image', 'twitter_image', 'canonical_url'].forEach((attr) => {
if (attrs[attr]) {
attrs[attr] = urlUtils.relativeToAbsolute(attrs[attr]);
['feature_image', 'canonical_url', 'posts_meta.og_image', 'posts_meta.twitter_image'].forEach((path) => {
const value = _.get(attrs, path);
if (value) {
_.set(attrs, path, urlUtils.relativeToAbsolute(value));
}
});

7
core/server/api/v2/utils/serializers/output/utils/url.js
View File

@ -56,9 +56,10 @@ const forPost = (id, attrs, frame) => {
}
});
['feature_image', 'og_image', 'twitter_image', 'canonical_url'].forEach((attr) => {
if (attrs[attr]) {
attrs[attr] = urlUtils.relativeToAbsolute(attrs[attr], attrs.url, urlOptions);
['feature_image', 'canonical_url', 'posts_meta.og_image', 'posts_meta.twitter_image'].forEach((path) => {
const value = _.get(attrs, path);
if (value) {
_.set(attrs, path, urlUtils.relativeToAbsolute(value));
}
});

6
test/unit/api/canary/utils/serializers/output/utils/url_spec.js
View File

@ -36,8 +36,10 @@ describe('Unit: canary/utils/serializers/output/utils/url', function () {
codeinjection_head: 'codeinjectionHead',
codeinjection_foot: 'codeinjectionFoot',
feature_image: 'featureImage',
og_image: 'ogImage',
twitter_image: 'twitterImage',
posts_meta: {
og_image: 'ogImage',
twitter_image: 'twitterImage'
},
canonical_url: 'canonicalUrl'
}));

6
test/unit/api/v2/utils/serializers/output/utils/url_spec.js
View File

@ -36,8 +36,10 @@ describe('Unit: v2/utils/serializers/output/utils/url', function () {
codeinjection_head: 'codeinjectionHead',
codeinjection_foot: 'codeinjectionFoot',
feature_image: 'featureImage',
og_image: 'ogImage',
twitter_image: 'twitterImage',
posts_meta: {
og_image: 'ogImage',
twitter_image: 'twitterImage'
},
canonical_url: 'canonicalUrl'
}));

6
test/unit/api/v3/utils/serializers/output/utils/url_spec.js
View File

@ -36,8 +36,10 @@ describe('Unit: v3/utils/serializers/output/utils/url', function () {
codeinjection_head: 'codeinjectionHead',
codeinjection_foot: 'codeinjectionFoot',
feature_image: 'featureImage',
og_image: 'ogImage',
twitter_image: 'twitterImage',
posts_meta: {
og_image: 'ogImage',
twitter_image: 'twitterImage'
},
canonical_url: 'canonicalUrl'
}));