TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-09-22 02:19:59 +03:00
Code Issues Projects Releases Wiki Activity

Removed unnecessary tags serializer

Browse Source 
refs: https://github.com/TryGhost/Toolbox/issues/245

- we don't need this serializer because the default serializer will call the tags mapper
- for now I've changed, rather than removed the tag serializer test as this shows default works the same!
This commit is contained in:
Hannah Wolfe 2022-03-21 20:49:01 +00:00
parent b28beed755
commit 9db1694647
3 changed files with 4 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/server/api/canary/utils/serializers/output/index.js
View File

@ -93,10 +93,6 @@ module.exports = {
return require('./files');
},
get tags() {
return require('./tags');
},
get users() {
return require('./users');
},

25
core/server/api/canary/utils/serializers/output/tags.js
View File

@ -1,25 +0,0 @@
const debug = require('@tryghost/debug')('api:canary:utils:serializers:output:tags');
const mappers = require('./mappers');
module.exports = {
all(models, apiConfig, frame) {
debug('all');
if (!models) {
return;
}
if (models.meta) {
frame.response = {
tags: models.data.map(model => mappers.tags(model, frame)),
meta: models.meta
};
return;
}
frame.response = {
tags: [mappers.tags(models, frame)]
};
}
};

8
test/unit/api/canary/utils/serializers/output/tags.test.js
View File

@ -20,7 +20,7 @@ describe('Unit: canary/utils/serializers/output/tags', function () {
});
it('calls the mapper when single tag present', function () {
const apiConfig = {};
const apiConfig = {docName: 'tags'};
const frame = {
options: {
context: {}
@ -29,14 +29,14 @@ describe('Unit: canary/utils/serializers/output/tags', function () {
const ctrlResponse = tagModel(testUtils.DataGenerator.forKnex.createTag());
serializers.output.tags.all(ctrlResponse, apiConfig, frame);
serializers.output.default.all(ctrlResponse, apiConfig, frame);
mappers.tags.callCount.should.equal(1);
mappers.tags.getCall(0).args.should.eql([ctrlResponse, frame]);
});
it('calls the mapper with multiple tags', function () {
const apiConfig = {};
const apiConfig = {docName: 'tags'};
const frame = {
options: {
context: {}
@ -51,7 +51,7 @@ describe('Unit: canary/utils/serializers/output/tags', function () {
meta: {}
});
serializers.output.tags.all(ctrlResponse, apiConfig, frame);
serializers.output.default.all(ctrlResponse, apiConfig, frame);
mappers.tags.callCount.should.equal(2);
mappers.tags.getCall(0).args.should.eql([ctrlResponse.data[0], frame]);