TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-28 22:43:30 +03:00
Code Issues Projects Releases Wiki Activity

Cleaned up launch complete behavior on dashboard

Browse Source 
no issue

- when switching from the user-specific `feature.launchComplete` flag to the global `settings.editorIsLaunchComplete` there was a missed replacement of `feature`->`settings` in the dashboard logic for showing "start creating content" CTA, resulting in it being always shown
- removes `launchComplete` feature flag setup on user which was used earlier for launch complete behavior
This commit is contained in:
Rishabh 2021-11-09 12:51:46 +05:30
parent f505caa034
commit a16681c8b5
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ghost/admin/app/services/feature.js
View File

@ -51,7 +51,6 @@ export default Service.extend({
emailAnalytics: feature('emailAnalytics'), emailAnalytics: feature('emailAnalytics'),
nightShift: feature('nightShift', {user: true, onChange: '_setAdminTheme'}), nightShift: feature('nightShift', {user: true, onChange: '_setAdminTheme'}),
launchComplete: feature('launchComplete', {user: true}),
multipleProducts: feature('multipleProducts'), multipleProducts: feature('multipleProducts'),
oauthLogin: feature('oauthLogin', {developer: true}), oauthLogin: feature('oauthLogin', {developer: true}),
customThemeSettings: feature('customThemeSettings'), customThemeSettings: feature('customThemeSettings'),

2
ghost/admin/app/templates/dashboard.hbs
View File

@ -137,7 +137,7 @@
<section class="gh-dashboard-area mixed"> <section class="gh-dashboard-area mixed">
{{#if (not this.feature.launchComplete)}} {{#if (not this.settings.editorIsLaunchComplete)}}
<div class="gh-dashboard-container start-contents"> <div class="gh-dashboard-container start-contents">
<div class="gh-dashboard-box blogpost"> <div class="gh-dashboard-box blogpost">
<h2>Start creating content</h2> <h2>Start creating content</h2>