TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-25 09:03:12 +03:00
Code Issues Projects Releases Wiki Activity

Fixed authors filter for posts with multiple authors (#993)

Browse Source 
no issue
- we need `?filter=authors:foo` to match all posts where `foo` is an author, the previous `?filter=author:foo` will only match posts where `foo` is the primary author
This commit is contained in:
Kevin Ansfield 2018-03-27 20:57:59 +01:00 committed by GitHub
parent 6c5f359628
commit a4061704a4
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ghost/admin/app/routes/posts.js
View File

@ -46,13 +46,13 @@ export default AuthenticatedRoute.extend(InfinityRoute, {
if (user.get('isAuthor')) {
// authors can only view their own posts
filterParams.author = user.get('slug');
filterParams.authors = user.get('slug');
} else if (user.get('isContributor')) {
// Contributors can only view their own draft posts
filterParams.author = user.get('slug');
filterParams.authors = user.get('slug');
queryParams.status = 'draft';
} else if (params.author) {
filterParams.author = params.author;
filterParams.authors = params.author;
}
let filter = this._filterString(filterParams);

6
ghost/admin/tests/acceptance/content-test.js
View File

@ -112,7 +112,7 @@ describe('Acceptance: Content', function () {
expect(lastRequest.queryParams.status, '"all" request status param').to.equal('all');
expect(lastRequest.queryParams.staticPages, '"all" request staticPages param').to.equal('all');
expect(lastRequest.queryParams.filter, '"editor" request filter param')
.to.equal(`author:${editor.slug}`);
.to.equal(`authors:${editor.slug}`);
// Displays editor post
// TODO: implement "filter" param support and fix mirage post->author association
@ -151,7 +151,7 @@ describe('Acceptance: Content', function () {
// API request includes author filter
let [lastRequest] = server.pretender.handledRequests.slice(-1);
expect(lastRequest.queryParams.filter).to.equal(`author:${author.slug}`);
expect(lastRequest.queryParams.filter).to.equal(`authors:${author.slug}`);
// only author's post is shown
expect(find('[data-test-post-id]').length, 'post count').to.equal(1);
@ -189,7 +189,7 @@ describe('Acceptance: Content', function () {
// API request includes author filter
let [lastRequest] = server.pretender.handledRequests.slice(-1);
expect(lastRequest.queryParams.filter).to.equal(`author:${contributor.slug}`);
expect(lastRequest.queryParams.filter).to.equal(`authors:${contributor.slug}`);
// only contributor's post is shown
expect(find('[data-test-post-id]').length, 'post count').to.equal(1);