Passed MembersAPI the OffersAPI over OfferRepository

no-issue

The MembersAPI using the OfferRepository coupled it to the internals of
the Offers Module - instead we pass the "external" API - so that we can
change the internals, and not have to update the MembersAPI's usage.
This commit is contained in:
Fabien O'Carroll 2021-10-13 11:09:50 +02:00
parent 00bcaeeb8c
commit a441825c3f
4 changed files with 6 additions and 7 deletions

View File

@ -187,7 +187,7 @@ function createApiInstance(config) {
},
stripeAPIService: stripeService.api,
logger: logging,
offerRepository: offersService.repository,
offersAPI: offersService.api,
labsService: labsService
});

View File

@ -26,7 +26,6 @@ module.exports = {
});
this.api = offersModule.api;
this.repository = offersModule.repository;
let initCalled = false;
if (labs.isSet('offers')) {

View File

@ -79,7 +79,7 @@
"@tryghost/limit-service": "0.6.4",
"@tryghost/logging": "0.1.7",
"@tryghost/magic-link": "1.0.13",
"@tryghost/members-api": "2.1.1",
"@tryghost/members-api": "2.2.0",
"@tryghost/members-csv": "1.1.7",
"@tryghost/members-importer": "0.3.3",
"@tryghost/members-offers": "0.6.0",

View File

@ -1488,10 +1488,10 @@
"@tryghost/domain-events" "^0.1.2"
"@tryghost/member-events" "^0.2.1"
"@tryghost/members-api@2.1.1":
version "2.1.1"
resolved "https://registry.yarnpkg.com/@tryghost/members-api/-/members-api-2.1.1.tgz#e4ef101fb7536f96f631b09d339e2e5735c01001"
integrity sha512-iLPfYQkzRQxWKoBWuYt2ytEn1RVKJFVtoQUBMwizyJgREU7qFkhoK00jXpc3plQXyhojIEVNJChE9VWG229kiA==
"@tryghost/members-api@2.2.0":
version "2.2.0"
resolved "https://registry.yarnpkg.com/@tryghost/members-api/-/members-api-2.2.0.tgz#58fdad00b42997222fac7a23c601f63bfca75e13"
integrity sha512-gkGvKzCFUHFxcBs/XXDwpkhE1+DQOJlB5CoIBtQEc/NMi/T4kZW+K2SeHxxkHmpUAediFTJFqgF1WDh2THfogw==
dependencies:
"@tryghost/debug" "^0.1.2"
"@tryghost/errors" "^0.2.9"