diff --git a/core/server/api/canary/settings.js b/core/server/api/canary/settings.js index dd2121fbd3..1b0cc9458b 100644 --- a/core/server/api/canary/settings.js +++ b/core/server/api/canary/settings.js @@ -96,6 +96,7 @@ module.exports = { }, updateMembersEmail: { + statusCode: 204, permissions: { method: 'edit' }, @@ -122,6 +123,7 @@ module.exports = { }, disconnectStripeConnectIntegration: { + statusCode: 204, permissions: { method: 'edit' }, diff --git a/core/server/api/canary/utils/serializers/output/settings.js b/core/server/api/canary/utils/serializers/output/settings.js index c0b9547b26..adb2e4e815 100644 --- a/core/server/api/canary/utils/serializers/output/settings.js +++ b/core/server/api/canary/utils/serializers/output/settings.js @@ -86,7 +86,5 @@ module.exports = { download: serializeData, upload: serializeData, - updateMembersEmail: passthrough, validateMembersEmailUpdate: passthrough, - disconnectStripeConnectIntegration: passthrough }; diff --git a/test/e2e-api/admin/__snapshots__/settings.test.js.snap b/test/e2e-api/admin/__snapshots__/settings.test.js.snap index 6ee6ffafa0..76921b57aa 100644 --- a/test/e2e-api/admin/__snapshots__/settings.test.js.snap +++ b/test/e2e-api/admin/__snapshots__/settings.test.js.snap @@ -1127,10 +1127,8 @@ exports[`Settings API can do disconnectStripeConnectIntegration 1: [headers] 1`] Object { "access-control-allow-origin": "http://127.0.0.1:2369", "cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0", - "content-length": "2", - "content-type": "application/json; charset=utf-8", "etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/, - "vary": "Origin, Accept-Encoding", + "vary": "Origin", "x-powered-by": "Express", } `; @@ -1139,10 +1137,8 @@ exports[`Settings API can do updateMembersEmail 1: [headers] 1`] = ` Object { "access-control-allow-origin": "http://127.0.0.1:2369", "cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0", - "content-length": "2", - "content-type": "application/json; charset=utf-8", "etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/, - "vary": "Origin, Accept-Encoding", + "vary": "Origin", "x-powered-by": "Express", } `; diff --git a/test/e2e-api/admin/settings.test.js b/test/e2e-api/admin/settings.test.js index c6007a7924..edf47597a7 100644 --- a/test/e2e-api/admin/settings.test.js +++ b/test/e2e-api/admin/settings.test.js @@ -171,7 +171,7 @@ describe('Settings API', function () { email: 'test@test.com', type: 'fromAddressUpdate' }) - .expectStatus(200) + .expectStatus(204) .expectEmptyBody() .matchHeaderSnapshot({ etag: anyEtag @@ -206,7 +206,7 @@ describe('Settings API', function () { it('can do disconnectStripeConnectIntegration', async function () { await agent .delete('/settings/stripe/connect/') - .expectStatus(200) + .expectStatus(204) .expectEmptyBody() .matchHeaderSnapshot({ etag: anyEtag