TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-23 11:55:01 +03:00
Code Issues Projects Releases Wiki Activity

Added logging for editor saveTask errors

Browse Source 
ref https://linear.app/tryghost/issue/ONC-323

- we're seeing a rare situation where the editor can get into a bad state when creating a new post that means saves silently fail
- added logging to help debug
This commit is contained in:
Kevin Ansfield 2024-09-13 00:00:56 +01:00
parent 24e9436155
commit a5b1f2e9fa
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ghost/admin/app/controllers/lexical-editor.js
View File

@ -652,8 +652,9 @@ export default class LexicalEditorController extends Controller {
return;
}
// re-throw if we have a general server error
if (error && !isInvalidError(error)) {
console.error(error); // eslint-disable-line no-console
Sentry.captureException(error, {tags: {savePostTask: true}});
this.send('error', error);
return;
}
@ -683,14 +684,9 @@ export default class LexicalEditorController extends Controller {
// }
}
// TODO: There's no need for (at least) most of these scratch values.
// Refactor so we're setting model attributes directly
// Set the properties that are indirected
// Set lexical equal to what's in the editor but create a copy so that
// nested objects/arrays don't keep references which can mean that both
// scratch and lexical get updated simultaneously
// Set lexical equal to what's in the editor
this.set('post.lexical', this.post.lexicalScratch || null);
// Set a default title
@ -698,6 +694,8 @@ export default class LexicalEditorController extends Controller {
this.set('post.titleScratch', DEFAULT_TITLE);
}
// TODO: There's no need for most of these scratch values.
// Refactor so we're setting model attributes directly
this.set('post.title', this.get('post.titleScratch'));
this.set('post.customExcerpt', this.get('post.customExcerptScratch'));
this.set('post.footerInjection', this.get('post.footerExcerptScratch'));