TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-24 19:33:02 +03:00
Code Issues Projects Releases Wiki Activity

Updated newsletter subtitle settings (#20289)

Browse Source 
REF MOM-168
- Updated the settings order to reflect the newsletter order
- Hid the subtitle setting if post title section is toggled off
This commit is contained in:
Sanne de Vries 2024-05-30 12:01:59 +02:00 committed by GitHub
parent a323739a1c
commit a8170752fa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 17 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
apps/admin-x-settings/src/components/settings/email/newsletters/NewsletterDetailModal.tsx
View File

@ -417,14 +417,8 @@ const Sidebar: React.FC<{
value={newsletter.title_color}
onChange={color => updateNewsletter({title_color: color})}
/>}
<Select
options={fontOptions}
selectedOption={fontOptions.find(option => option.value === newsletter.body_font_category)}
testId='body-font-select'
title='Body style'
onSelect={option => updateNewsletter({body_font_category: option?.value})}
/>
{hasNewsletterSubtitle &&
<ToggleGroup gap='lg'>
{(hasNewsletterSubtitle && newsletter.show_post_title_section) &&
<Toggle
checked={newsletter.show_subhead}
direction="rtl"
@ -438,6 +432,14 @@ const Sidebar: React.FC<{
label='Feature image'
onChange={e => updateNewsletter({show_feature_image: e.target.checked})}
/>
</ToggleGroup>
<Select
options={fontOptions}
selectedOption={fontOptions.find(option => option.value === newsletter.body_font_category)}
testId='body-font-select'
title='Body style'
onSelect={option => updateNewsletter({body_font_category: option?.value})}
/>
</Form>
<Form className='mt-6' gap='sm' margins='lg' title='Footer'>

2
apps/admin-x-settings/src/components/settings/email/newsletters/NewsletterPreviewContent.tsx
View File

@ -135,7 +135,7 @@ const NewsletterPreviewContent: React.FC<{
Your email newsletter
</h2>
{(hasNewsletterSubtitle && showSubhead) && (
<p className="mb-4 text-[1.6rem] leading-[1.7] text-black">A subtitle that highlights the key points of your newsletter.</p>
<p className="mb-4 text-pretty text-[1.6rem] leading-[1.7] text-black">A subtitle can help highlight key points and engage your readers.</p>
)}
<div className={clsx(
'flex w-full justify-between text-center text-md leading-none text-grey-700',