TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-24 14:43:08 +03:00
Code Issues Projects Releases Wiki Activity

Unsilenced deprecations that are no longer triggered

Browse Source 
no issue

- cleaned up the `deprecation-workflow.js` file by removing deprecations that are no longer being triggered by our test suite or general app usage (if they are still triggered in untested areas it will be useful to see the logs)
- updated usages of `{{gh-text-field}}` to use it's `shouldFocus` attribute rather than directly overriding it's `autofocus` computed property
This commit is contained in:
Kevin Ansfield 2020-01-09 17:20:13 +00:00
parent 3c30e73701
commit a862cb6b6a
5 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ghost/admin/app/templates/components/gh-unsplash.hbs
View File

@ -21,7 +21,7 @@
name="searchKeyword"
placeholder="Search free high-resolution photos"
tabindex="1"
autofocus="autofocus"
shouldFocus=true
autocorrect="off"
value=(readonly this.unsplash.searchTerm)
input=(action "search" value="target.value")

2
ghost/admin/app/templates/components/modal-invite-new-user.hbs
View File

@ -16,7 +16,7 @@
type="email"
placeholder="Email Address"
name="email"
autofocus="autofocus"
shouldFocus=true
autocapitalize="off"
autocorrect="off"
value=(readonly email)

6
ghost/admin/app/templates/components/modal-webhook-form.hbs
View File

@ -17,7 +17,7 @@
name="name"
class="gh-input mt1"
placeholder="Webhook name..."
autofocus="autofocus"
shouldFocus=true
autocapitalize="off"
autocorrect="off"
data-test-input="webhook-name"}}
@ -57,7 +57,7 @@
name="targetUrl"
class="gh-input mt1"
placeholder="Webhook target URL..."
autofocus="autofocus"
shouldFocus=true
autocapitalize="off"
autocorrect="off"
data-test-input="webhook-targetUrl"}}
@ -76,7 +76,7 @@
name="secret"
class="gh-input mt1"
placeholder="Webhook secret..."
autofocus="autofocus"
shouldFocus=true
autocapitalize="off"
autocorrect="off"
data-test-input="webhook-secret"}}

4
ghost/admin/app/templates/reset.hbs
View File

@ -11,7 +11,7 @@
placeholder="Password"
class="password"
autocorrect="off"
autofocus="autofocus"
shouldFocus=true
value=(readonly this.newPassword)
input=(action (mut this.newPassword) value="target.value")}}
</span>
@ -25,7 +25,7 @@
placeholder="Confirm Password"
class="password"
autocorrect="off"
autofocus="autofocus"
shouldFocus=true
value=(readonly this.ne2Password)
input=(action (mut this.ne2Password) value="target.value")}}
</span>

6
ghost/admin/config/deprecation-workflow.js
View File

@ -2,12 +2,6 @@ self.deprecationWorkflow = self.deprecationWorkflow || {};
self.deprecationWorkflow.config = {
workflow: [
{handler: 'silence', matchId: 'ember-views.curly-components.jquery-element'},
{handler: 'silence', matchId: 'computed-property.override'},
{handler: 'silence', matchId: 'application-controller.router-properties'},
{handler: 'silence', matchId: 'events.remove-all-listeners'},
{handler: 'silence', matchId: 'ember-polyfills.deprecate-merge'},
{handler: 'silence', matchId: 'events.inherited-function-listeners'},
{handler: 'silence', matchId: 'ember-component.send-action'},
// revert once ember-infinity removes usage of `isVisible`
// https://github.com/ember-infinity/ember-infinity/pull/399
{handler: 'silence', matchId: 'ember-component.is-visible'}