TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-28 14:03:48 +03:00
Code Issues Projects Releases Wiki Activity

Added newsletter read permission (#14519)

Browse Source 
refs https://github.com/TryGhost/Team/issues/1533

- Needed to create the read newsletter endpoint to make the newsletter resource more consistent with the other resources
- Read is available to admins like other newsletter actions
This commit is contained in:
Thibaut Patel 2022-04-20 15:25:41 +02:00 committed by GitHub
parent 5a2219bec3
commit ae664e9cad
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 23 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
core/server/data/migrations/versions/4.45/2022-04-20-11-25-add-newsletter-read-permission.js Normal file
View File

@ -0,0 +1,9 @@
const {addPermissionWithRoles} = require('../../utils');
module.exports = addPermissionWithRoles({
name: 'Read newsletters',
action: 'read',
object: 'newsletter'
}, [
'Administrator'
]);

5
core/server/data/schema/fixtures/fixtures.json
View File

@ -546,6 +546,11 @@
"action_type": "browse",
"object_type": "newsletter"
},
{
"name": "Read newsletters",
"action_type": "read",
"object_type": "newsletter"
},
{
"name": "Add newsletters",
"action_type": "add",

5
test/integration/migrations/migration.test.js
View File

@ -45,7 +45,7 @@ describe('Database Migration (special functions)', function () {
const permissions = this.obj;
// If you have to change this number, please add the relevant `havePermission` checks below
permissions.length.should.eql(95);
permissions.length.should.eql(96);
permissions.should.havePermission('Export database', ['Administrator', 'DB Backup Integration']);
permissions.should.havePermission('Import database', ['Administrator', 'DB Backup Integration']);
@ -164,6 +164,7 @@ describe('Database Migration (special functions)', function () {
permissions.should.havePermission('Edit custom theme settings', ['Administrator']);
permissions.should.havePermission('Browse newsletters', ['Administrator']);
permissions.should.havePermission('Read newsletters', ['Administrator']);
permissions.should.havePermission('Edit newsletters', ['Administrator']);
permissions.should.havePermission('Add newsletters', ['Administrator']);
});
@ -223,7 +224,7 @@ describe('Database Migration (special functions)', function () {
result.roles.at(7).get('name').should.eql('Scheduler Integration');
// Permissions
result.permissions.length.should.eql(95);
result.permissions.length.should.eql(96);
result.permissions.toJSON().should.be.CompletePermissions();
});
});

2
test/unit/server/data/schema/integrity.test.js
View File

@ -36,7 +36,7 @@ const validateRouteSettings = require('../../../../../core/server/services/route
describe('DB version integrity', function () {
// Only these variables should need updating
const currentSchemaHash = 'ae71340a8c89f6580b2eb06101f003b4';
const currentFixturesHash = '2fb171312dfdd1dc3a569dfb845ac6f5';
const currentFixturesHash = '2fe576bcde3428c3063c05b2f2c37367';
const currentSettingsHash = '71fa38d0c805c18ceebe0fda80886230';
const currentRoutesHash = '3d180d52c663d173a6be791ef411ed01';

5
test/utils/fixtures/fixtures.json
View File

@ -107,6 +107,11 @@
"action_type": "browse",
"object_type": "notification"
},
{
"name": "Read newsletters",
"action_type": "read",
"object_type": "newsletter"
},
{
"name": "Add notifications",
"action_type": "add",