TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-28 05:37:34 +03:00
Code Issues Projects Releases Wiki Activity

Promoted multiple newsletters flag (backend) to GA (#14609)

Browse Source 
refs https://github.com/TryGhost/Team/issues/1566
This commit is contained in:
Matt Hanley 2022-04-27 19:02:56 +01:00 committed by GitHub
parent f5bd647100
commit b2e36b2f6f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/shared/labs.js
View File

@ -21,6 +21,7 @@ const GA_FEATURES = [
'selectablePortalLinks',
'membersTableStatus',
'improvedOnboarding',
'multipleNewsletters',
'membersActivityFeed'
];
@ -36,7 +37,6 @@ const ALPHA_FEATURES = [
'urlCache',
'beforeAfterCard',
'tweetGridCard',
'multipleNewsletters',
'multipleNewslettersUI',
'dashboardV5',
'publishingFlow'

6
test/e2e-api/admin/__snapshots__/settings.test.js.snap
View File

@ -152,7 +152,7 @@ Object {
"key": "labs",
"type": "object",
"updated_at": StringMatching /\\\\d\\{4\\}-\\\\d\\{2\\}-\\\\d\\{2\\}T\\\\d\\{2\\}:\\\\d\\{2\\}:\\\\d\\{2\\}\\\\\\.000Z/,
"value": "{\\"multipleProducts\\":true,\\"tierWelcomePages\\":true,\\"tierName\\":true,\\"selectablePortalLinks\\":true,\\"membersTableStatus\\":true,\\"improvedOnboarding\\":true,\\"membersActivityFeed\\":true,\\"members\\":true}",
"value": "{\\"multipleProducts\\":true,\\"tierWelcomePages\\":true,\\"tierName\\":true,\\"selectablePortalLinks\\":true,\\"membersTableStatus\\":true,\\"improvedOnboarding\\":true,\\"multipleNewsletters\\":true,\\"membersActivityFeed\\":true,\\"members\\":true}",
},
Object {
"created_at": StringMatching /\\\\d\\{4\\}-\\\\d\\{2\\}-\\\\d\\{2\\}T\\\\d\\{2\\}:\\\\d\\{2\\}:\\\\d\\{2\\}\\\\\\.000Z/,
@ -192,7 +192,7 @@ exports[`Settings API Can edit a setting 2: [headers] 1`] = `
Object {
"access-control-allow-origin": "http://127.0.0.1:2369",
"cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0",
"content-length": "3979",
"content-length": "4008",
"content-type": "application/json; charset=utf-8",
"etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/,
"vary": "Origin, Accept-Encoding",
@ -873,7 +873,7 @@ Object {
"key": "labs",
"type": "object",
"updated_at": StringMatching /\\\\d\\{4\\}-\\\\d\\{2\\}-\\\\d\\{2\\}T\\\\d\\{2\\}:\\\\d\\{2\\}:\\\\d\\{2\\}\\\\\\.000Z/,
"value": "{\\"activitypub\\":true,\\"oauthLogin\\":true,\\"membersActivity\\":true,\\"urlCache\\":true,\\"beforeAfterCard\\":true,\\"tweetGridCard\\":true,\\"multipleNewsletters\\":true,\\"multipleNewslettersUI\\":true,\\"dashboardV5\\":true,\\"publishingFlow\\":true,\\"multipleProducts\\":true,\\"tierWelcomePages\\":true,\\"tierName\\":true,\\"selectablePortalLinks\\":true,\\"membersTableStatus\\":true,\\"improvedOnboarding\\":true,\\"membersActivityFeed\\":true,\\"members\\":true}",
"value": "{\\"activitypub\\":true,\\"oauthLogin\\":true,\\"membersActivity\\":true,\\"urlCache\\":true,\\"beforeAfterCard\\":true,\\"tweetGridCard\\":true,\\"multipleNewslettersUI\\":true,\\"dashboardV5\\":true,\\"publishingFlow\\":true,\\"multipleProducts\\":true,\\"tierWelcomePages\\":true,\\"tierName\\":true,\\"selectablePortalLinks\\":true,\\"membersTableStatus\\":true,\\"improvedOnboarding\\":true,\\"multipleNewsletters\\":true,\\"membersActivityFeed\\":true,\\"members\\":true}",
},
Object {
"created_at": StringMatching /\\\\d\\{4\\}-\\\\d\\{2\\}-\\\\d\\{2\\}T\\\\d\\{2\\}:\\\\d\\{2\\}:\\\\d\\{2\\}\\\\\\.000Z/,

10
test/unit/server/services/mega/mega.test.js
View File

@ -15,7 +15,10 @@ describe('MEGA', function () {
// via transformEmailRecipientFilter
it('throws when "free" or "paid" strings are used as a email_recipient_filter', async function () {
const postModel = {
get: sinon.stub().returns('free')
get: sinon.stub().returns('free'),
related: sinon.stub().returns({
fetch: sinon.stub().returns(null)
})
};
try {
@ -30,7 +33,10 @@ describe('MEGA', function () {
// via transformEmailRecipientFilter
it('throws when "none" is used as a email_recipient_filter', async function () {
const postModel = {
get: sinon.stub().returns('none')
get: sinon.stub().returns('none'),
related: sinon.stub().returns({
fetch: sinon.stub().returns(null)
})
};
try {

3
test/unit/server/services/members/middleware.test.js
View File

@ -233,7 +233,8 @@ describe('Members Service Middleware', function () {
members_support_address: 'noreply@example.com',
prices: [],
products: [],
portal_products: ''
portal_products: '',
newsletters: []
}
}).should.be.true();
});