Moved members screen filter components into components/members

no issue

- currently the components are screen-specific rather than generalised so shouldn't have the `gh-` prefix
- fixed linter error for confusing `{{#unless}}...{{else}}` usage
This commit is contained in:
Kevin Ansfield 2022-02-08 15:06:48 +00:00
parent b287c881eb
commit b80ce527e5
6 changed files with 12 additions and 10 deletions

View File

@ -1792,3 +1792,4 @@ add|ember-template-lint|no-passed-in-event-handlers|50|12|50|12|8deb1881d48f9362
add|ember-template-lint|no-passed-in-event-handlers|51|12|51|12|db0e4b1769dec0725404801686f1e4fbf6fbb795|1644278400000|1646870400000|1649458800000|app/components/gh-members-filter-value.hbs
add|ember-template-lint|no-passed-in-event-handlers|97|8|97|8|8deb1881d48f936269c7960537ad72bfe4dfd760|1644278400000|1646870400000|1649458800000|app/components/gh-members-filter-value.hbs
add|ember-template-lint|no-passed-in-event-handlers|98|8|98|8|db0e4b1769dec0725404801686f1e4fbf6fbb795|1644278400000|1646870400000|1649458800000|app/components/gh-members-filter-value.hbs
remove|ember-template-lint|simple-unless|138|4|138|4|02b279bc993a1ee6632c7e6edf341a2aabc519cb|1643760000000|1646352000000|1648940400000|app/templates/members.hbs

View File

@ -27,8 +27,9 @@ const FILTER_OPTIONS = {
]
};
export default class GhMembersFilterValue extends Component {
export default class MembersFilterValue extends Component {
@tracked filterValue;
constructor(...args) {
super(...args);
this.availableFilterOptions = FILTER_OPTIONS;

View File

@ -43,7 +43,7 @@
/>
{{svg-jar "arrow-down-small"}}
</span>
<GhMembersFilterValue
<Members::FilterValue
@filter={{filter}}
@setFilterValue={{this.setFilterValue}}
@onLabelEdit={{@onLabelEdit}}

View File

@ -100,7 +100,7 @@ const FILTER_VALUE_OPTIONS = {
{label: 'Incomplete - Expired', name: 'incomplete_expired'}
]
};
export default class GhMembersFilter extends Component {
export default class MembersFilter extends Component {
@service session
@tracked filters = A([
EmberObject.create({

View File

@ -20,7 +20,7 @@
</div>
<div class="view-actions-top-row">
<GhMembersFilter
<Members::Filter
@isFiltered={{this.isFiltered}}
@onApplyFilter={{this.applyFilter}}
@defaultFilterParam={{this.filterParam}}
@ -97,7 +97,11 @@
</section>
</GhCanvasHeader>
{{#unless this.members.loading}}
{{#if this.members.loading}}
<div class="gh-content">
<GhLoadingSpinner />
</div>
{{else}}
<section class="view-container">
{{#if this.members}}
<div class="gh-list-scrolling {{if (lt this.members.length 6) "gh-list-with-helpsection"}}">
@ -169,11 +173,7 @@
</div>
{{/if}}
</section>
{{else}}
<div class="gh-content">
<GhLoadingSpinner />
</div>
{{/unless}}
{{/if}}
</section>
{{outlet}}