TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-07 03:22:21 +03:00
Code Issues Projects Releases Wiki Activity

Allowed editing member's email

Browse Source 
no issue

- After investigating effects of allowing editing email there were no significant blockers found, so there is no reason not to allow editing this field
This commit is contained in:
Nazar Gargol 2020-02-21 16:00:13 +08:00
parent b5183204e9
commit b9db9fa15e
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
core/server/api/canary/utils/validators/input/schemas/members-edit.json
View File

@ -20,6 +20,12 @@
"maxLength": 191, "maxLength": 191,
"pattern": "^([^,]|$)" "pattern": "^([^,]|$)"
}, },
"email": {
"type": "string",
"minLength": 1,
"maxLength": 191,
"pattern": "^([^,]|$)"
},
"note": { "note": {
"type": "string", "type": "string",
"minLength": 0, "minLength": 0,
@ -34,9 +40,6 @@
"id": { "id": {
"strip": true "strip": true
}, },
"email": {
"strip": true
},
"labels": { "labels": {
"$ref": "members#/definitions/member-labels" "$ref": "members#/definitions/member-labels"
}, },

4
core/test/regression/api/canary/admin/members_spec.js
View File

@ -168,8 +168,8 @@ describe('Members API', function () {
jsonResponse.members.should.have.length(1); jsonResponse.members.should.have.length(1);
localUtils.API.checkResponse(jsonResponse.members[0], 'member', 'stripe'); localUtils.API.checkResponse(jsonResponse.members[0], 'member', 'stripe');
jsonResponse.members[0].name.should.equal(memberChanged.name); jsonResponse.members[0].name.should.equal(memberChanged.name);
jsonResponse.members[0].email.should.not.equal(memberChanged.email); jsonResponse.members[0].email.should.equal(memberChanged.email);
jsonResponse.members[0].email.should.equal(memberToChange.email); jsonResponse.members[0].email.should.not.equal(memberToChange.email);
}); });
}); });
}); });