mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-25 20:03:12 +03:00
Upgraded no-skipped-test rule to error
refs: 895bffec1f
- Allowing tests to be skipped masks issues where people temporarily skip tests to fix later and accidentally commit
- Converting this to an error allows us to see when this happens easily
- In future, when we're done with the dance of using ESLint rules to signpost codebase improvements, we may want to downgrade this back to a warning
- This would enable us to have deliberate, temporarily skipped tests in the codebase, if there's a usecase for that with pushing to main regularly
This commit is contained in:
parent
49f20820ef
commit
bea04e437d
@ -23,7 +23,7 @@ module.exports = {
|
|||||||
'no-unused-vars': 'off',
|
'no-unused-vars': 'off',
|
||||||
'no-useless-escape': 'off',
|
'no-useless-escape': 'off',
|
||||||
|
|
||||||
'ghost/mocha/no-skipped-tests': 'warn',
|
'ghost/mocha/no-skipped-tests': 'error',
|
||||||
|
|
||||||
// TODO: remove these custom rules and fix problems in test files
|
// TODO: remove these custom rules and fix problems in test files
|
||||||
'ghost/mocha/max-top-level-suites': 'off',
|
'ghost/mocha/max-top-level-suites': 'off',
|
||||||
|
Loading…
Reference in New Issue
Block a user