TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-25 03:44:29 +03:00
Code Issues Projects Releases Wiki Activity

Upgraded no-skipped-test rule to error

Browse Source 
refs: 895bffec1f

- Allowing tests to be skipped masks issues where people temporarily skip tests to fix later and accidentally commit
- Converting this to an error allows us to see when this happens easily
- In future, when we're done with the dance of using ESLint rules to signpost codebase improvements, we may want to downgrade this back to a warning
- This would enable us to have deliberate, temporarily skipped tests in the codebase, if there's a usecase for that with pushing to main regularly
This commit is contained in:
Hannah Wolfe 2021-05-26 14:57:43 +01:00
parent 49f20820ef
commit bea04e437d
No known key found for this signature in database
GPG Key ID: 9F8C7532D0A6BA55
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/.eslintrc.js
View File

@ -23,7 +23,7 @@ module.exports = {
'no-unused-vars': 'off', 'no-unused-vars': 'off',
'no-useless-escape': 'off', 'no-useless-escape': 'off',
'ghost/mocha/no-skipped-tests': 'warn', 'ghost/mocha/no-skipped-tests': 'error',
// TODO: remove these custom rules and fix problems in test files // TODO: remove these custom rules and fix problems in test files
'ghost/mocha/max-top-level-suites': 'off', 'ghost/mocha/max-top-level-suites': 'off',