Removed ember-sticky-element in favour of native position: sticky

no issue

- native `position: sticky` support is now good enough across the board of our supported browser versions to use in place of a JS version for our use cases
- `ember-sticky-element` is preventing the dependency update of `ember-in-viewport` so removing it will allow a lot of our sub-dependencies to be updated
This commit is contained in:
Kevin Ansfield 2020-10-01 08:36:55 +01:00
parent 86531ebf16
commit c0149ee997
3 changed files with 4 additions and 13 deletions

View File

@ -1,7 +1,8 @@
{{#if this.icon}}
<StickyElement @top={{this.iconTop}} @bottom={{36}}>
<div class="sticky" style="top: {{this.iconTop}}px; margin-bottom: {{this.iconTop}}px">
{{svg-jar this.icon class=this.iconClass}}
</StickyElement>
</div>
<div style="margin-top: -{{this.iconTop}}px"></div>
{{/if}}
{{yield (hash

View File

@ -97,7 +97,6 @@
"ember-simple-auth": "3.0.0",
"ember-sinon": "5.0.0",
"ember-source": "3.21.3",
"ember-sticky-element": "0.2.3",
"ember-svg-jar": "2.2.3",
"ember-test-selectors": "5.0.0",
"ember-truth-helpers": "2.1.0",

View File

@ -6194,7 +6194,7 @@ ember-in-element-polyfill@^1.0.0:
ember-cli-htmlbars "^4.3.1"
ember-cli-version-checker "^5.0.2"
ember-in-viewport@3.5.8, ember-in-viewport@~3.0.0, ember-in-viewport@~3.7.2:
ember-in-viewport@3.5.8, ember-in-viewport@~3.7.2:
version "3.5.8"
resolved "https://registry.yarnpkg.com/ember-in-viewport/-/ember-in-viewport-3.5.8.tgz#da03f5e69c5e5e6cbd048f0db8de0b05c2e3e68f"
integrity sha512-2GBK5KbNYiGADy433tN3yHnxZ77wSnVyMezx23cr3qs2gwac+5ta2FkOTiKibNkGmWE/Mk/c7zcF7sDk1jy5DA==
@ -6480,15 +6480,6 @@ ember-source@3.21.3:
semver "^6.1.1"
silent-error "^1.1.1"
ember-sticky-element@0.2.3:
version "0.2.3"
resolved "https://registry.yarnpkg.com/ember-sticky-element/-/ember-sticky-element-0.2.3.tgz#39702e0fc0f04905a7b34add61a85a9186d3d16b"
integrity sha512-AtKkM8zh6LK5FsPxtsDywUSodGk5c2AI03vcgk995dC5Z7DG4XLJoAwV0FZM5RYnymnYEJvOs6VTcIM8uwcX5w==
dependencies:
ember-cli-babel "^6.8.2"
ember-cli-htmlbars "^2.0.1"
ember-in-viewport "~3.0.0"
ember-svg-jar@2.2.3:
version "2.2.3"
resolved "https://registry.yarnpkg.com/ember-svg-jar/-/ember-svg-jar-2.2.3.tgz#632f8d6a999ceb1c815a135fbc2bd681b856330b"