TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-25 03:44:29 +03:00
Code Issues Projects Releases Wiki Activity

Updated api services to be memoized in case of re-renders

Browse Source 
no issue
This commit is contained in:
Jono Mingard 2023-06-08 11:08:00 +12:00
parent 446841ce9c
commit c1628f46e0
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ghost/admin-x-settings/src/components/providers/ServiceProvider.tsx
View File

@ -1,4 +1,4 @@
import React, {createContext} from 'react';
import React, {createContext, useMemo} from 'react';
import setupGhostApi from '../../utils/api';
export interface FileService {
@ -20,14 +20,14 @@ const ServicesContext = createContext<ServicesContextProps>({
});
const ServicesProvider: React.FC<ServicesProviderProps> = ({children, ghostVersion}) => {
// TODO: Will this re-render? (if so, will it make duplicate requests because the api object is different?)
const apiService = setupGhostApi({ghostVersion});
const fileService = {
const apiService = useMemo(() => setupGhostApi({ghostVersion}), [ghostVersion]);
const fileService = useMemo(() => ({
uploadImage: async (file: File): Promise<string> => {
const response = await apiService.images.upload({file});
return response.images[0].url;
}
};
}), [apiService]);
return (
<ServicesContext.Provider value={{
api: apiService,