TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-25 11:55:03 +03:00
Code Issues Projects Releases Wiki Activity

Removed the source attributiont table from Post Analytics page and added dummy metric to Conversions tab

Browse Source 
refs https://github.com/TryGhost/Team/issues/2157
This commit is contained in:
James Morris 2022-10-25 11:05:35 +01:00
parent 441ec742c0
commit c533af61a9
3 changed files with 15 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
ghost/admin/app/components/posts/analytics.hbs
View File

@ -120,35 +120,13 @@
</Tabs::Tabs>
{{#if this.isLoaded }}
<div class="gh-post-analytics-split">
{{#if this.showSources }}
<div class="gh-post-analytics-box column gh-post-analytics-source-attribution">
<h3 class="gh-dashboard-metric-label">Post growth</h3>
{{#if (is-empty this.sources) }}
<div class="attribution-list-empty">
{{svg-jar "members-outline"}}
<h4>No new members for this post</h4>
<p>Once someone signs up, you'll be able to see where they came from here.</p>
</div>
{{else}}
<MemberAttribution::SourceAttributionTable
@sources={{this.sources}}
@sortColumn={{this.sortColumn}}
@setSortColumn={{this.setSortColumn}}
class="gh-dashboard-attribution-list gh-dashboard-list"
/>
{{/if}}
</div>
{{#if this.showLinks }}
{{#if (is-empty this.links) }}
{{!-- Empty state --}}
{{else}}
<Posts::LinksTable @links={{this.links}} @updateLink={{this.updateLink}} />
{{/if}}
{{#if this.showLinks }}
{{#if (is-empty this.links) }}
{{!-- Empty state --}}
{{else}}
<Posts::LinksTable @links={{this.links}} @updateLink={{this.updateLink}} />
{{/if}}
{{/if}}
</div>
{{/if}}
<div class="gh-post-analytics-box resources">
<a href="https://ghost.org/help/post-analytics/" target="_blank" class="gh-post-analytics-resource" rel="noopener noreferrer">

7
ghost/admin/app/components/posts/post-activity-feed.hbs
View File

@ -40,7 +40,7 @@
</div>
</div>
{{else}}
<div class="gh-dashboard-list-body">
<div class="gh-dashboard-list-body {{if (eq this.eventType "conversion") "gh-dashboard-list-four-cols" }}">
{{#each eventsFetcher.data as |event|}}
{{#let (parse-member-event event) as |parsedEvent|}}
<div class="gh-dashboard-list-item">
@ -56,6 +56,11 @@
</span>
</span>
</div>
{{#if (eq this.eventType "conversion")}}
<div class="gh-dashboard-list-item-sub">
Source
</div>
{{/if}}
<div class="gh-dashboard-list-item-sub">
<span class="gh-dashboard-list-subtext">{{moment-from-now parsedEvent.timestamp}}</span>
</div>

14
ghost/admin/app/styles/layouts/content.css
View File

@ -854,12 +854,6 @@ a.gh-post-list-signups.active:hover > span, a.gh-post-list-conversions.active:ho
gap: 24px;
}
.gh-post-analytics-split {
display: flex;
gap: 2.4rem;
min-height: 445px;
}
.gh-newsletter-clicks-header {
align-items: center;
font-size: 1.55rem;
@ -1643,6 +1637,9 @@ a.gh-post-list-cta.stats.is-hovered:hover > * {
grid-template-columns: 40% 40% 20%;
}
.gh-tabs-analytics .gh-dashboard-list-four-cols .gh-dashboard-list-item {
grid-template-columns: 35% 25% 20% 20%;
}
@media (max-width: 1200px) {
.gh-tabs-analytics .tab{
@ -1664,11 +1661,6 @@ a.gh-post-list-cta.stats.is-hovered:hover > * {
.gh-tabs-analytics p {
font-size: 1.6rem;
}
.gh-post-analytics-split {
flex-direction: column;
gap: 0;
}
}
@media (max-width: 440px) {