TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-24 06:35:49 +03:00
Code Issues Projects Releases Wiki Activity

Added additional logging for Sentry issue.id:2451728694

Browse Source 
no issue

- Sentry was showing `card` being undefined at times when attempting to select/edit a card after it's inserted in `replaceWithCardSection()` (called by card menus and text expansions) but it's not been reproducible in local environments
- it's unclear if the problem occurs due to the card render not happening in the immediate render queue or if it's some other problem
- added a retry if the card is not found after the first render plus logs to Sentry and console when the unexpected state occurs for better insight
This commit is contained in:
Kevin Ansfield 2021-09-09 12:58:38 +01:00
parent c9f1a6bc48
commit c97e06751e
1 changed files with 28 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
ghost/admin/lib/koenig-editor/addon/components/koenig-editor.js
View File

@ -21,6 +21,7 @@ import {TrackedObject} from 'tracked-built-ins';
import {action} from '@ember/object';
import {assign} from '@ember/polyfills';
import {camelize, capitalize} from '@ember/string';
import {captureMessage} from '@sentry/browser';
import {createParserPlugins} from '@tryghost/kg-parser-plugins';
import {getContentFromPasteEvent} from 'mobiledoc-kit/utils/parse-utils';
import {getLinkMarkupFromRange} from '../utils/markup-utils';
@ -614,14 +615,38 @@ export default Component.extend({
// assume that the last card in the list is the one we want to
// select. Needs to be scheduled afterRender so that the new card
// is actually present
run.schedule('afterRender', this, function () {
let card = this.componentCards.lastObject;
const editOrSelectCard = (card) => {
if (card.koenigOptions.hasEditMode) {
this.editCard(card);
} else if (card.koenigOptions.selectAfterInsert) {
this.selectCard(card);
}
};
run.schedule('afterRender', this, function () {
let card = this.componentCards.lastObject;
// Sentry was showing `card` being undefined at times (id: 2451728694).
// Retrying with logging to see if it's a case of multiple render loops
// or some other underlying issue
// TODO: check Sentry for issue occurence after 4.13.0
if (!card) {
captureMessage('replaceWithCardSection: card was not present after first render');
console.warn('replaceWithCardSection: card was not present after first render'); // eslint-disable-line
run.schedule('afterRender', this, function () {
card = this.componentCards.lastObject;
if (!card) {
captureMessage('replaceWithCardSection: card was not present after second render');
console.warn('replaceWithCardSection: card was not present after second render'); // eslint-disable-line
}
editOrSelectCard(card);
});
}
editOrSelectCard(card);
});
},