mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-28 22:43:30 +03:00
Added regression tests for handling of HTML errors (#816)
closes https://github.com/TryGhost/Ghost/issues/8203 - rename `version-mismatch-test.js` to the more generic `error-handling-test.js` - add tests to simulate receiving HTML errors (eg, the type of error received from CloudFlare for a gateway timeout)
This commit is contained in:
Kevin Ansfield
Aileen Nowak
parent
11cbe1abba
commit
cba36b867a
158
ghost/admin/tests/acceptance/error-handling-test.js
Normal file
158
ghost/admin/tests/acceptance/error-handling-test.js
Normal file
@ -0,0 +1,158 @@
|
||||
/* jshint expr:true */
|
||||
import Mirage from 'ember-cli-mirage';
|
||||
import destroyApp from '../helpers/destroy-app';
|
||||
import startApp from '../helpers/start-app';
|
||||
import testSelector from 'ember-test-selectors';
|
||||
import {afterEach, beforeEach, describe, it} from 'mocha';
|
||||
import {authenticateSession} from 'ghost-admin/tests/helpers/ember-simple-auth';
|
||||
import {expect} from 'chai';
|
||||
import {versionMismatchResponse} from 'ghost-admin/mirage/utils';
|
||||
|
||||
let htmlErrorResponse = function () {
|
||||
return new Mirage.Response(
|
||||
504,
|
||||
{'Content-Type': 'text/html'},
|
||||
'<!DOCTYPE html><head><title>Server Error</title></head><body>504 Gateway Timeout</body></html>'
|
||||
);
|
||||
};
|
||||
|
||||
describe('Acceptance: Error Handling', function() {
|
||||
let application;
|
||||
|
||||
beforeEach(function() {
|
||||
application = startApp();
|
||||
});
|
||||
|
||||
afterEach(function() {
|
||||
destroyApp(application);
|
||||
});
|
||||
|
||||
describe('VersionMismatch errors', function () {
|
||||
describe('logged in', function () {
|
||||
beforeEach(function () {
|
||||
let role = server.create('role', {name: 'Administrator'});
|
||||
server.create('user', {roles: [role]});
|
||||
|
||||
return authenticateSession(application);
|
||||
});
|
||||
|
||||
it('displays an alert and disables navigation when saving', async function () {
|
||||
server.createList('post', 3);
|
||||
|
||||
// mock the post save endpoint to return version mismatch
|
||||
server.put('/posts/:id', versionMismatchResponse);
|
||||
|
||||
await visit('/');
|
||||
await click('.posts-list li:nth-of-type(2) a'); // select second post
|
||||
await click(testSelector('publishmenu-trigger'));
|
||||
await click(testSelector('publishmenu-save')); // "Save post"
|
||||
|
||||
// has the refresh to update alert
|
||||
expect(find('.gh-alert').length).to.equal(1);
|
||||
expect(find('.gh-alert').text()).to.match(/refresh/);
|
||||
|
||||
// try navigating back to the content list
|
||||
await click('.gh-nav-main-content');
|
||||
|
||||
expect(currentPath()).to.equal('editor.edit');
|
||||
});
|
||||
|
||||
it('displays alert and aborts the transition when navigating', async function () {
|
||||
await visit('/');
|
||||
|
||||
// mock the tags endpoint to return version mismatch
|
||||
server.get('/tags/', versionMismatchResponse);
|
||||
|
||||
await click('.gh-nav-settings-tags');
|
||||
|
||||
// navigation is blocked on loading screen
|
||||
expect(currentPath()).to.equal('settings.tags_loading');
|
||||
|
||||
// has the refresh to update alert
|
||||
expect(find('.gh-alert').length).to.equal(1);
|
||||
expect(find('.gh-alert').text()).to.match(/refresh/);
|
||||
});
|
||||
|
||||
it('displays alert and aborts the transition when an ember-ajax error is thrown whilst navigating', async function () {
|
||||
server.get('/configuration/timezones/', versionMismatchResponse);
|
||||
|
||||
await visit('/settings/tags');
|
||||
await click('.gh-nav-settings-general');
|
||||
|
||||
// navigation is blocked
|
||||
expect(currentPath()).to.equal('settings.general_loading');
|
||||
|
||||
// has the refresh to update alert
|
||||
expect(find('.gh-alert').length).to.equal(1);
|
||||
expect(find('.gh-alert').text()).to.match(/refresh/);
|
||||
});
|
||||
|
||||
it('can be triggered when passed in to a component', async function () {
|
||||
server.post('/subscribers/csv/', versionMismatchResponse);
|
||||
|
||||
await visit('/subscribers');
|
||||
await click('.gh-btn:contains("Import CSV")');
|
||||
await fileUpload('.fullscreen-modal input[type="file"]', ['test'], {name: 'test.csv'});
|
||||
|
||||
// alert is shown
|
||||
expect(find('.gh-alert').length).to.equal(1);
|
||||
expect(find('.gh-alert').text()).to.match(/refresh/);
|
||||
});
|
||||
});
|
||||
|
||||
describe('logged out', function () {
|
||||
it('displays alert', async function () {
|
||||
server.post('/authentication/token', versionMismatchResponse);
|
||||
|
||||
await visit('/signin');
|
||||
await fillIn('[name="identification"]', 'test@example.com');
|
||||
await fillIn('[name="password"]', 'password');
|
||||
await click('.gh-btn-blue');
|
||||
|
||||
// has the refresh to update alert
|
||||
expect(find('.gh-alert').length).to.equal(1);
|
||||
expect(find('.gh-alert').text()).to.match(/refresh/);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('CloudFlare errors', function () {
|
||||
beforeEach(function () {
|
||||
let [role] = server.db.roles.where({name: 'Administrator'});
|
||||
server.create('user', {roles: [role]});
|
||||
|
||||
server.loadFixtures();
|
||||
|
||||
authenticateSession(application);
|
||||
});
|
||||
|
||||
it('handles Ember Data HTML response', async function () {
|
||||
server.put('/posts/1/', htmlErrorResponse);
|
||||
server.create('post');
|
||||
|
||||
await visit('/editor/1');
|
||||
await click(testSelector('publishmenu-trigger'));
|
||||
await click(testSelector('publishmenu-save'));
|
||||
|
||||
andThen(() => {
|
||||
expect(find('.gh-alert').length).to.equal(1);
|
||||
expect(find('.gh-alert').text()).to.not.match(/html>/);
|
||||
expect(find('.gh-alert').text()).to.match(/There was a problem on the server/);
|
||||
});
|
||||
});
|
||||
|
||||
it('handles ember-ajax HTML response', async function () {
|
||||
server.del('/themes/foo/', htmlErrorResponse);
|
||||
|
||||
await visit('/settings/design');
|
||||
await click(`${testSelector('theme-id', 'foo')} ${testSelector('theme-delete-button')}`);
|
||||
await click(`.fullscreen-modal ${testSelector('delete-button')}`);
|
||||
|
||||
andThen(() => {
|
||||
expect(find('.gh-alert').length).to.equal(1);
|
||||
expect(find('.gh-alert').text()).to.not.match(/html>/);
|
||||
expect(find('.gh-alert').text()).to.match(/There was a problem on the server/);
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
@ -1,107 +0,0 @@
|
||||
/* jshint expr:true */
|
||||
import destroyApp from '../helpers/destroy-app';
|
||||
import startApp from '../helpers/start-app';
|
||||
import testSelector from 'ember-test-selectors';
|
||||
import {afterEach, beforeEach, describe, it} from 'mocha';
|
||||
import {authenticateSession} from 'ghost-admin/tests/helpers/ember-simple-auth';
|
||||
import {expect} from 'chai';
|
||||
import {versionMismatchResponse} from 'ghost-admin/mirage/utils';
|
||||
|
||||
describe('Acceptance: Version Mismatch', function() {
|
||||
let application;
|
||||
|
||||
beforeEach(function() {
|
||||
application = startApp();
|
||||
});
|
||||
|
||||
afterEach(function() {
|
||||
destroyApp(application);
|
||||
});
|
||||
|
||||
describe('logged in', function () {
|
||||
beforeEach(function () {
|
||||
let role = server.create('role', {name: 'Administrator'});
|
||||
server.create('user', {roles: [role]});
|
||||
|
||||
return authenticateSession(application);
|
||||
});
|
||||
|
||||
it('displays an alert and disables navigation when saving', async function () {
|
||||
server.createList('post', 3);
|
||||
|
||||
// mock the post save endpoint to return version mismatch
|
||||
server.put('/posts/:id', versionMismatchResponse);
|
||||
|
||||
await visit('/');
|
||||
await click('.posts-list li:nth-of-type(2) a'); // select second post
|
||||
await click(testSelector('publishmenu-trigger'));
|
||||
await click(testSelector('publishmenu-save')); // "Save post"
|
||||
|
||||
// has the refresh to update alert
|
||||
expect(find('.gh-alert').length).to.equal(1);
|
||||
expect(find('.gh-alert').text()).to.match(/refresh/);
|
||||
|
||||
// try navigating back to the content list
|
||||
await click('.gh-nav-main-content');
|
||||
|
||||
expect(currentPath()).to.equal('editor.edit');
|
||||
});
|
||||
|
||||
it('displays alert and aborts the transition when navigating', async function () {
|
||||
await visit('/');
|
||||
|
||||
// mock the tags endpoint to return version mismatch
|
||||
server.get('/tags/', versionMismatchResponse);
|
||||
|
||||
await click('.gh-nav-settings-tags');
|
||||
|
||||
// navigation is blocked on loading screen
|
||||
expect(currentPath()).to.equal('settings.tags_loading');
|
||||
|
||||
// has the refresh to update alert
|
||||
expect(find('.gh-alert').length).to.equal(1);
|
||||
expect(find('.gh-alert').text()).to.match(/refresh/);
|
||||
});
|
||||
|
||||
it('displays alert and aborts the transition when an ember-ajax error is thrown whilst navigating', async function () {
|
||||
server.get('/configuration/timezones/', versionMismatchResponse);
|
||||
|
||||
await visit('/settings/tags');
|
||||
await click('.gh-nav-settings-general');
|
||||
|
||||
// navigation is blocked
|
||||
expect(currentPath()).to.equal('settings.general_loading');
|
||||
|
||||
// has the refresh to update alert
|
||||
expect(find('.gh-alert').length).to.equal(1);
|
||||
expect(find('.gh-alert').text()).to.match(/refresh/);
|
||||
});
|
||||
|
||||
it('can be triggered when passed in to a component', async function () {
|
||||
server.post('/subscribers/csv/', versionMismatchResponse);
|
||||
|
||||
await visit('/subscribers');
|
||||
await click('.gh-btn:contains("Import CSV")');
|
||||
await fileUpload('.fullscreen-modal input[type="file"]', ['test'], {name: 'test.csv'});
|
||||
|
||||
// alert is shown
|
||||
expect(find('.gh-alert').length).to.equal(1);
|
||||
expect(find('.gh-alert').text()).to.match(/refresh/);
|
||||
});
|
||||
});
|
||||
|
||||
describe('logged out', function () {
|
||||
it('displays alert', async function () {
|
||||
server.post('/authentication/token', versionMismatchResponse);
|
||||
|
||||
await visit('/signin');
|
||||
await fillIn('[name="identification"]', 'test@example.com');
|
||||
await fillIn('[name="password"]', 'password');
|
||||
await click('.gh-btn-blue');
|
||||
|
||||
// has the refresh to update alert
|
||||
expect(find('.gh-alert').length).to.equal(1);
|
||||
expect(find('.gh-alert').text()).to.match(/refresh/);
|
||||
});
|
||||
});
|
||||
});
|
||||
Loading…
Reference in New Issue
Block a user