TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-28 21:33:24 +03:00
Code Issues Projects Releases Wiki Activity

Refactored async function to throw errors

Browse Source 
no-issue

There's no need to return rejected promises in an async function as
thrown errors will behave the same, this just makes it a little cleaner.
This commit is contained in:
Fabien O'Carroll 2020-09-28 13:06:58 +01:00
parent 6e96f44f39
commit d2bb50a436
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ghost/members-api/index.js
View File

@ -164,9 +164,9 @@ module.exports = function MembersApi({
async function setMemberGeolocationFromIp(email, ip) {
if (!email || !ip) {
return Promise.reject(new common.errors.IncorrectUsageError({
throw new common.errors.IncorrectUsageError({
message: 'setMemberGeolocationFromIp() expects email and ip arguments to be present'
}));
});
}
const member = await users.get(email, {
@ -174,9 +174,9 @@ module.exports = function MembersApi({
});
if (!member) {
return Promise.reject(new common.errors.NotFoundError({
throw new common.errors.NotFoundError({
message: `Member with email address ${email} does not exist`
}));
});
}
// max request time is 500ms so shouldn't slow requests down too much