TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-25 11:55:03 +03:00
Code Issues Projects Releases Wiki Activity

Fixed editor key commands throwing errors when range has no section

Browse Source 
closes Sentry ADMIN-CC8
closes Sentry ADMIN-DDM
closes Sentry ADMIN-C9F

- there are situations where the editor range when key commands are triggered does not have a head section which then throws errors due to the commands assuming there will always be a section present
- added a guard to key commands that use the head section to abort early and fall back to default Mobiledoc behaviour when the section is missing
This commit is contained in:
Kevin Ansfield 2022-11-24 13:10:11 +00:00
parent 64329d716e
commit d4ea9c877d
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
ghost/admin/lib/koenig-editor/addon/options/key-commands.js
View File

@ -78,6 +78,10 @@ export const DEFAULT_KEY_COMMANDS = [{
run(editor, koenig) {
let {isCollapsed, head: {offset, section}} = editor.range;
if (!section) {
return false;
}
// if cursor is at beginning of a heading, insert a blank paragraph above
if (isCollapsed && offset === 0 && section.tagName && section.tagName.match(/^h\d$/)) {
editor.run((postEditor) => {
@ -144,6 +148,11 @@ export const DEFAULT_KEY_COMMANDS = [{
str: 'BACKSPACE',
run(editor, koenig) {
let {head, isCollapsed, head: {marker, offset, section}} = editor.range;
if (!section) {
return false;
}
let {next, prev} = section;
// if a card is selected we should delete the card then place the cursor
@ -257,6 +266,10 @@ export const DEFAULT_KEY_COMMANDS = [{
run(editor, koenig) {
let {isCollapsed, head: {offset, section}} = editor.range;
if (!section) {
return false;
}
// if a card is selected we should delete the card then place the cursor
// at the beginning of the next section or select the following card
if (koenig.selectedCard) {
@ -291,6 +304,11 @@ export const DEFAULT_KEY_COMMANDS = [{
str: 'UP',
run(editor, koenig) {
let {isCollapsed, head: {offset, section}} = editor.range;
if (!section) {
return false;
}
let prevSection = section.isListItem && !section.prev ? section.parent.prev : section.prev;
if (isCollapsed && (offset === 0 || section.isCardSection) && !prevSection) {
@ -314,6 +332,10 @@ export const DEFAULT_KEY_COMMANDS = [{
run(editor, koenig) {
let {isCollapsed, head: {offset, section}} = editor.range;
if (!section) {
return false;
}
// trigger a closure action to indicate that the caret "left" the top of
// the editor canvas if the caret is at the very beginning of the doc
let prevSection = section.isListItem && !section.prev ? section.parent.prev : section.prev;