TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-25 11:55:03 +03:00
Code Issues Projects Releases Wiki Activity

Fixed migrations to 4.x from 1.x

Browse Source 
no-issue

The slack setting in 1.x did not have a `username` property. When
updating from 1.x, the migration to move the slack setting from a JSON
blob to two individual settings, would assume that the setting in the
database would have a value for the `username` property. This resulted
in errors on SQLite "sqlite does not support inserting default values."

The fix here is to add defaults when reading from the database, meaning
that we will _never_ attempt to insert `undefined`
This commit is contained in:
Fabien O'Carroll 2021-03-01 15:06:37 +00:00 committed by Fabien 'egg' O'Carroll
parent 3b6c55ec53
commit d8fa54024b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/server/data/migrations/versions/4.0/16-refactor-slack-setting.js
View File

@ -41,8 +41,8 @@ module.exports = createIrreversibleMigration(async (knex) => {
// }]
const value = JSON.parse(slackSetting.value)[0];
slackUrl = value.url;
slackUsername = value.username;
slackUrl = value.url || '';
slackUsername = value.username || 'Ghost';
} catch (err) {
slackUrl = '';
slackUsername = 'Ghost';